feat(app): Add toggle to turn on/off robot rail lights #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
added
feature
Codecov Report
@@ Coverage Diff @@
## edge #1710 +/- ##
==========================================
+ Coverage 34.85% 34.97% +0.12%
==========================================
Files 340 340
Lines 5563 5589 +26
==========================================
+ Hits 1939 1955 +16
- Misses 3624 3634 +10
Continue to review full report at Codecov.
|
IanLondon
approved these changes
Jun 18, 2018
Unexpected, but dug into it and the |
b-cooper
approved these changes
Jun 18, 2018
| import {LabeledToggle, LabeledButton} from '../controls' | ||
|
|
||
| import type {State, Dispatch} from '../../types' | ||
| import type {Robot} from '../../robot' | ||
|
|
||
| type OP = Robot | ||
|
|
||
| type SP = {} | ||
| type SP = { |
There was a problem hiding this comment.
You could make these type defs single lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This PR wires the lights toggle UI from #1708 to the
/robot/lightsendpoint from #1709 so that the user can turn their robot's lights on and off.Closes #1684
changelog
review requests
Try it out with a robot! Does not work with Virtual Smoothie. Sunset is up to date with the necessary endpoints