fix(app): Enable robot update even if API reports up-to-date #1721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This PR is also serving as the ticket. With the addition of firmware updates in the robot update flow, we ran into an issue where sometimes, the firmware would not update (for various valid / invalid reasons). However, because the API update usually succeeds,
/health
would report that the robot was up to date, and the update button would become disabled. This would then remove any firmware upgrade path from the user until the next API update.Until we figure out a more refined approach to separating and communicating smoothie firmware, this PR removes the button disable logic and allows the user to send the update request even if the robot appears up to date.
changelog
review requests
Tested on Sunset. Robot update should work even if robot is already up to date