Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Enable robot update even if API reports up-to-date #1721

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Jun 19, 2018

overview

This PR is also serving as the ticket. With the addition of firmware updates in the robot update flow, we ran into an issue where sometimes, the firmware would not update (for various valid / invalid reasons). However, because the API update usually succeeds, /health would report that the robot was up to date, and the update button would become disabled. This would then remove any firmware upgrade path from the user until the next API update.

Until we figure out a more refined approach to separating and communicating smoothie firmware, this PR removes the button disable logic and allows the user to send the update request even if the robot appears up to date.

2018-06-19 11 42 32

changelog

  • fix(app): Enable robot update even if API reports up-to-date

review requests

Tested on Sunset. Robot update should work even if robot is already up to date

@mcous mcous added bug app Affects the `app` project ready for review fix PR fixes a bug labels Jun 19, 2018
@mcous mcous requested review from Kadee80, b-cooper and IanLondon June 19, 2018 15:45
Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎎

@codecov
Copy link

codecov bot commented Jun 19, 2018

Codecov Report

Merging #1721 into edge will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             edge   #1721      +/-   ##
=========================================
- Coverage   35.01%     35%   -0.02%     
=========================================
  Files         344     344              
  Lines        5646    5648       +2     
=========================================
  Hits         1977    1977              
- Misses       3669    3671       +2
Impacted Files Coverage Δ
...pp/src/components/RobotSettings/InformationCard.js 0% <ø> (ø) ⬆️
app/src/components/RobotSettings/UpdateModal.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf4881...171dcde. Read the comment docs.

@mcous mcous merged commit 16bb8eb into edge Jun 19, 2018
@mcous mcous deleted the app_enable-robot-update-always branch June 19, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project bug fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants