fix(api): Fix RPC reporting wrong models for v1.3 pipettes

[mcous]

overview

This PR also serving as the bug ticket.

As reported by @HenryOpentrons, the app was reporting that an incorrect pipette was attached in the Tip Probe screen even if the correct pipette was attached. Upon further investigation, this was only happening with v1.3 pipettes, and was due to the fact that the RPC API was always reporting pipettes used in the protocol as v1 pipettes, regardless of what was attached to the robot.

changelog

• fix(api): Fix RPC reporting wrong models for v1.3 pipettes
  • Removed redundant is_simulating check for retrieving correct model string of pipettes created from config
  • Added attached pipette caching call prior to RPC protocol simulation to ensure proper pipette models were picked up

review requests

I've tested this on Sunset with a v1.3 P50. We need to ensure:

• Virtual smoothie doesn't crap out completely with these changes
• Real robot with v1 pipette does not show "incorrect pipette attached" warning
• Real robot with v1.3 pipette does not show "incorrect pipette attached" warning

[codecov]

Codecov Report

Merging #1691 into edge will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             edge    #1691   +/-   ##
=======================================
  Coverage   34.68%   34.68%           
=======================================
  Files         342      342           
  Lines        5576     5576           
=======================================
  Hits         1934     1934           
  Misses       3642     3642

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad5e74...3ea0e37. Read the comment docs.

[btmorr]

⚡️