fix(api): Fixes bug in replacing substring of old p50 pipettes #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n with v13 instead of v1.3
Codecov Report
@@ Coverage Diff @@
## edge #1717 +/- ##
=======================================
Coverage 35.09% 35.09%
=======================================
Files 340 340
Lines 5570 5570
=======================================
Hits 1955 1955
Misses 3615 3615Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This PR fixes a bug with older p50 pipettes not being recognized by the robot.
A small subset of p50 pipettes were written with model strings ending with
"v13"instead of the currently used format"v1.3". The driver'sread_pipette_model()method was intending to replace those old substrings with the new one, but was replacing with an invalid string (missing the underscore)