Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the GSL exp1 ceiling diagnostic #947

Merged
merged 6 commits into from
May 2, 2024
Merged

Updates to the GSL exp1 ceiling diagnostic #947

merged 6 commits into from
May 2, 2024

Conversation

jaymes-kenyon
Copy link
Contributor

@jaymes-kenyon jaymes-kenyon commented May 1, 2024 •
edited
Loading

[Addresses issue #944]

This updates the GSL "exp1" (experimental) ceiling diagnostic for possible use in RRFSv1. Recent RRFS retrospective tests with this code have produced improved verification statistics relative to the existing "exp1" code. In particular, this update accomplishes the following:

  1. Reduces the threshold cloud fraction used to detect a ceiling, from 0.50 (current) to 0.41 (new).

  2. Revises the code to detect shallow fog, and makes this code more readable / understandable. Any shallow fog that is detected will not yield a very low ceiling.

Testing of this code has been successful on Hera in a RRFS case (CONUS domain).

@jaymes-kenyon
Updates to the GSL ceiling exp1 diagnostic:
36c39b5 
1) reducing the threshold cloud fraction to detect a ceiling (from 0.50 to 0.41)
2) revamping the code for detecting shallow fog
@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon My UPP RTs indicate the impact only in 'CEIL' PRSLEV dataset of RRFS test as
827:761040843:CEIL:cloud ceiling:rpn_corr=0.975146:rpn_rms=1017.83
I would think that is expected change. Please validate my test at /home/Wen.Meng/stmp2/fv3r_2023062800 on Hera.

@jaymes-kenyon
Copy link
Contributor Author

@WenMeng-NOAA: Thanks for the test! This is the expected change—looks good!

@WenMeng-NOAA
Copy link
Collaborator

@WenMeng-NOAA: Thanks for the test! This is the expected change—looks good!

@jaymes-kenyon Thanks !

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. Please refer to my testing at /home/Wen.Meng/stmp2 on Hera:

Wen.Meng@hfe07 stmp2$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp   75 May  2 12:50 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp  541 May  2 12:52 fv3r_2023062800/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 1009 May  2 12:52 rtma_2023040400_pe_test/PRSLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  541 May  2 12:52 fv3r_2023062800_pe_test/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 1009 May  2 12:52 rtma_2023040400/PRSLEV00.tm00.diff

@WenMeng-NOAA WenMeng-NOAA added RRFS Baseline Change The baselines of the UPP regression tests are changed. Ready for Review This PR is ready for code review. labels May 2, 2024
@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs have completed on WCOSS2. The baselines for fv3r and 3drtma will be recreated with this PR.

@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. Please refer to my testing at /home/Wen.Meng/stmp2 on Hera:

Wen.Meng@hfe07 stmp2$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp   75 May  2 12:50 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp  541 May  2 12:52 fv3r_2023062800/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 1009 May  2 12:52 rtma_2023040400_pe_test/PRSLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  541 May  2 12:52 fv3r_2023062800_pe_test/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 1009 May  2 12:52 rtma_2023040400/PRSLEV00.tm00.diff

Logs pushed up. RTs across Hera, Hercules, and Orion match with your results.

@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 14d6613 into NOAA-EMC:develop May 2, 2024
5 checks passed
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request May 2, 2024
Closed
@jaymes-kenyon jaymes-kenyon deleted the rrfs_ceiling_mods branch May 2, 2024 16:22
@jaymes-kenyon jaymes-kenyon mentioned this pull request May 2, 2024
Closed
@WenMeng-NOAA WenMeng-NOAA linked an issue May 2, 2024 that may be closed by this pull request
RRFS: Update the exp1 ceiling diagnostic #944
Closed
@jaymes-kenyon jaymes-kenyon mentioned this pull request May 3, 2024
Merged
15 tasks
DavidHuber-NOAA added a commit to DavidHuber-NOAA/UPP that referenced this pull request Sep 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into feature/ss_180
9669aba 
* origin/develop:
  Updates to support MPAS applications (RRFS and HFIP) (NOAA-EMC#1029)
  Add 6-hrly max winds at 10m to SFS (NOAA-EMC#1019)
  Update jet.lua (NOAA-EMC#1027)
  Updates to support UPP use with MPAS (NOAA-EMC#1018)
  [develop]: Turn on WARN_AS_ERROR for Doxygen Documentation Builds (NOAA-EMC#1023)
  Sample PR for testing (NOAA-EMC#1007)
  Enable template 4-49 to obtain aerosol ensemble information (NOAA-EMC#1011)
  Relocate gfs/gefs/sfs control files (NOAA-EMC#990)
  update g2tmp on aws to 1.12.0 (NOAA-EMC#996)
  [develop]: Update requirements files (NOAA-EMC#994)
  Bump zipp from 3.17.0 to 3.19.1 in /doc/UserGuide (NOAA-EMC#991)
  remove stack-python load for Gaea build (NOAA-EMC#993)
  Bump certifi from 2024.2.2 to 2024.7.4 in /doc/UserGuide (NOAA-EMC#988)
  [develop]: Add Doxygen variable definitions to modules (NOAA-EMC#965)
  Read bucket either as an integer or float (NOAA-EMC#984)
  Update Orion module file for Rocky 9 upgrade (NOAA-EMC#987)
  UPP bugfixes for inline post and g2tmpl 1.12.0 compatibility (and number concentration updates) (NOAA-EMC#974)
  Sync the RRFS hotfix NOAA-EMC#967 and NOAA-EMC#968. (NOAA-EMC#979)
  Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UserGuide (NOAA-EMC#981)
  Fix for hydrostatic runs - write out Omega and HGT from model output (NOAA-EMC#959)
  Bump requests from 2.31.0 to 2.32.0 in /doc/UserGuide (NOAA-EMC#963)
  Correct rt.sh paths (NOAA-EMC#957)
  Updates to use GRIB2 template 4.9 for QPFFFG and QPFARI variables in RRFS (NOAA-EMC#929)
  Add hourly averaged smoke PM2.5 and dust PM10 (NOAA-EMC#917)
  Update Namelist documentation for all namelist options (NOAA-EMC#940)
  update gtg code revision to v.4.16.3 (NOAA-EMC#954)
  Bump jinja2 from 3.1.3 to 3.1.4 in /doc/UserGuide (NOAA-EMC#953)
  Clean up labeling for 15-min accumulated fields (NOAA-EMC#948)
  Updates to the GSL exp1 ceiling diagnostic (NOAA-EMC#947)
  Additional RT log information (NOAA-EMC#941)
  add cmake load to modulefile/gaea.lua (NOAA-EMC#945)
  RRFS updates (NOAA-EMC#938)
  add module for AWS (NOAA-EMC#934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernandoAndrade-NOAA FernandoAndrade-NOAA FernandoAndrade-NOAA approved these changes

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

Assignees
No one assigned
Labels
Baseline Change The baselines of the UPP regression tests are changed. Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RRFS: Update the exp1 ceiling diagnostic
3 participants
@jaymes-kenyon @WenMeng-NOAA @FernandoAndrade-NOAA