Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for hydrostatic runs - write out Omega and HGT from model output #959

Merged
merged 6 commits into from
Jun 14, 2024

Conversation

KarinaAsmar-NOAA
Copy link
Contributor

This PR should fix UPP offline post hydrostatic runs by writing out Omega and HGT from model output. The fix is synced with inline post as described in Issue #946 . See issue for test results with GFSv17, GEFSv13, SFSv1.

@WenMeng-NOAA WenMeng-NOAA added SFSV1 Ready for Review This PR is ready for code review. labels Jun 12, 2024
Copy link

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on R&D platforms. From my testing on Hera, no changed results.

@FernandoAndrade-NOAA
Copy link
Collaborator

Hera RTs completed with no changes, waiting on Hercules. Orion will be unavailable due to the OS migration.

@FernandoAndrade-NOAA
Copy link
Collaborator

Hera RTs completed with no changes, waiting on Hercules. Orion will be unavailable due to the OS migration.

It looks like the fv3r pe_test did not run/complete. I will rerun on hera and append results to the log.

@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on R&D platforms. From my testing on Hera, no changed results.

RTs completed on Hera and Hercules, no changes in my results.

@WenMeng-NOAA WenMeng-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label Jun 14, 2024
@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs were completed on WCOSS2 without changed results.

@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA linked an issue Jun 14, 2024 that may be closed by this pull request
@WenMeng-NOAA WenMeng-NOAA merged commit a215c43 into NOAA-EMC:develop Jun 14, 2024
3 of 5 checks passed
@KarinaAsmar-NOAA KarinaAsmar-NOAA deleted the hydro_fix branch June 14, 2024 10:25
DavidHuber-NOAA added a commit to DavidHuber-NOAA/UPP that referenced this pull request Sep 9, 2024
* origin/develop:
  Updates to support MPAS applications (RRFS and HFIP) (NOAA-EMC#1029)
  Add 6-hrly max winds at 10m to SFS (NOAA-EMC#1019)
  Update jet.lua (NOAA-EMC#1027)
  Updates to support UPP use with MPAS (NOAA-EMC#1018)
  [develop]: Turn on WARN_AS_ERROR for Doxygen Documentation Builds (NOAA-EMC#1023)
  Sample PR for testing (NOAA-EMC#1007)
  Enable template 4-49 to obtain aerosol ensemble information (NOAA-EMC#1011)
  Relocate gfs/gefs/sfs control files (NOAA-EMC#990)
  update g2tmp on aws to 1.12.0 (NOAA-EMC#996)
  [develop]: Update requirements files (NOAA-EMC#994)
  Bump zipp from 3.17.0 to 3.19.1 in /doc/UserGuide (NOAA-EMC#991)
  remove stack-python load for Gaea build (NOAA-EMC#993)
  Bump certifi from 2024.2.2 to 2024.7.4 in /doc/UserGuide (NOAA-EMC#988)
  [develop]: Add Doxygen variable definitions to modules (NOAA-EMC#965)
  Read bucket either as an integer or float (NOAA-EMC#984)
  Update Orion module file for Rocky 9 upgrade (NOAA-EMC#987)
  UPP bugfixes for inline post and g2tmpl 1.12.0 compatibility (and number concentration updates) (NOAA-EMC#974)
  Sync the RRFS hotfix NOAA-EMC#967 and NOAA-EMC#968. (NOAA-EMC#979)
  Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UserGuide (NOAA-EMC#981)
  Fix for hydrostatic runs - write out Omega and HGT from model output (NOAA-EMC#959)
  Bump requests from 2.31.0 to 2.32.0 in /doc/UserGuide (NOAA-EMC#963)
  Correct rt.sh paths (NOAA-EMC#957)
  Updates to use GRIB2 template 4.9 for QPFFFG and QPFARI variables in RRFS (NOAA-EMC#929)
  Add hourly averaged smoke PM2.5 and dust PM10 (NOAA-EMC#917)
  Update Namelist documentation for all namelist options (NOAA-EMC#940)
  update gtg code revision to v.4.16.3 (NOAA-EMC#954)
  Bump jinja2 from 3.1.3 to 3.1.4 in /doc/UserGuide (NOAA-EMC#953)
  Clean up labeling for 15-min accumulated fields (NOAA-EMC#948)
  Updates to the GSL exp1 ceiling diagnostic (NOAA-EMC#947)
  Additional RT log information (NOAA-EMC#941)
  add cmake load to modulefile/gaea.lua (NOAA-EMC#945)
  RRFS updates (NOAA-EMC#938)
  add module for AWS (NOAA-EMC#934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review. SFSV1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write out HGT for hydrostatic run and omega from the model output
4 participants