Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct rt.sh paths #957

Merged

Conversation

FernandoAndrade-NOAA
Copy link
Collaborator

This PR will correct spack-stack paths in rt.sh that should now be in sync with the recent modulefile spack-stack paths update. The new path on hercules does not contain stack-python, so the system's 3.10.8 will be loaded instead.

@FernandoAndrade-NOAA FernandoAndrade-NOAA self-assigned this May 13, 2024
@FernandoAndrade-NOAA FernandoAndrade-NOAA added the bug Something isn't working label May 13, 2024
@FernandoAndrade-NOAA FernandoAndrade-NOAA linked an issue May 13, 2024 that may be closed by this pull request
@FernandoAndrade-NOAA
Copy link
Collaborator Author

The new spack-stack path on Orion does not contain the required wgrib2/2.0.8 and grib-util/1.3.0 for the fv3gfs test cases. A temporary workaround discussed was to revert the job scripts for the fv3gfs test cases back to the "unified-env" spack-stack 1.6.0 paths. There are no changes in results. This PR is ready for merging.

@FernandoAndrade-NOAA
Copy link
Collaborator Author

@HuiyaChuang-NOAA Please review and approve the changes in this PR, there are only minor path updates within rt.sh and a switch to Hercules' default python. The failures in the CI actions are due to a version issue with g2tmpl 1.12.0.

@FernandoAndrade-NOAA FernandoAndrade-NOAA added Ready for Review This PR is ready for code review. No Baseline Change No baseline of the UPP regression tests are made. labels May 17, 2024
@FernandoAndrade-NOAA
Copy link
Collaborator Author

There are no changes in this PR that would affect WCOSS2 results, skipping for this PR.

@FernandoAndrade-NOAA FernandoAndrade-NOAA merged commit c6013dd into NOAA-EMC:develop May 24, 2024
3 of 5 checks passed
@FernandoAndrade-NOAA FernandoAndrade-NOAA deleted the bugfix/rt-paths branch July 31, 2024 18:29
DavidHuber-NOAA added a commit to DavidHuber-NOAA/UPP that referenced this pull request Sep 9, 2024
* origin/develop:
  Updates to support MPAS applications (RRFS and HFIP) (NOAA-EMC#1029)
  Add 6-hrly max winds at 10m to SFS (NOAA-EMC#1019)
  Update jet.lua (NOAA-EMC#1027)
  Updates to support UPP use with MPAS (NOAA-EMC#1018)
  [develop]: Turn on WARN_AS_ERROR for Doxygen Documentation Builds (NOAA-EMC#1023)
  Sample PR for testing (NOAA-EMC#1007)
  Enable template 4-49 to obtain aerosol ensemble information (NOAA-EMC#1011)
  Relocate gfs/gefs/sfs control files (NOAA-EMC#990)
  update g2tmp on aws to 1.12.0 (NOAA-EMC#996)
  [develop]: Update requirements files (NOAA-EMC#994)
  Bump zipp from 3.17.0 to 3.19.1 in /doc/UserGuide (NOAA-EMC#991)
  remove stack-python load for Gaea build (NOAA-EMC#993)
  Bump certifi from 2024.2.2 to 2024.7.4 in /doc/UserGuide (NOAA-EMC#988)
  [develop]: Add Doxygen variable definitions to modules (NOAA-EMC#965)
  Read bucket either as an integer or float (NOAA-EMC#984)
  Update Orion module file for Rocky 9 upgrade (NOAA-EMC#987)
  UPP bugfixes for inline post and g2tmpl 1.12.0 compatibility (and number concentration updates) (NOAA-EMC#974)
  Sync the RRFS hotfix NOAA-EMC#967 and NOAA-EMC#968. (NOAA-EMC#979)
  Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UserGuide (NOAA-EMC#981)
  Fix for hydrostatic runs - write out Omega and HGT from model output (NOAA-EMC#959)
  Bump requests from 2.31.0 to 2.32.0 in /doc/UserGuide (NOAA-EMC#963)
  Correct rt.sh paths (NOAA-EMC#957)
  Updates to use GRIB2 template 4.9 for QPFFFG and QPFARI variables in RRFS (NOAA-EMC#929)
  Add hourly averaged smoke PM2.5 and dust PM10 (NOAA-EMC#917)
  Update Namelist documentation for all namelist options (NOAA-EMC#940)
  update gtg code revision to v.4.16.3 (NOAA-EMC#954)
  Bump jinja2 from 3.1.3 to 3.1.4 in /doc/UserGuide (NOAA-EMC#953)
  Clean up labeling for 15-min accumulated fields (NOAA-EMC#948)
  Updates to the GSL exp1 ceiling diagnostic (NOAA-EMC#947)
  Additional RT log information (NOAA-EMC#941)
  add cmake load to modulefile/gaea.lua (NOAA-EMC#945)
  RRFS updates (NOAA-EMC#938)
  add module for AWS (NOAA-EMC#934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correction to rt.sh spack-stack paths
2 participants