Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add module for AWS #934

Merged
merged 3 commits into from
Apr 27, 2024
Merged

add module for AWS #934

merged 3 commits into from
Apr 27, 2024

Conversation

weihuang-jedi
Copy link
Contributor

We are working on port EMC global-workflow to AWS.
To make start with, we need to add a new module file to load modules on AWS.

This PR is to solve issue #933.

@WenMeng-NOAA WenMeng-NOAA added the enhancement New feature or request label Apr 18, 2024
@WenMeng-NOAA
Copy link
Collaborator

@weihuang-jedi Did you test your PR on AWS?

@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Apr 25, 2024
@WenMeng-NOAA
Copy link
Collaborator

@weihuang-jedi Can you sync your branch with the latest UPP develop?

aerorahul
aerorahul approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@weihuang-jedi
Copy link
Contributor Author

Synced the fork with origin.

@WenMeng-NOAA
Copy link
Collaborator

@weihuang-jedi Can you sync your branch for PR processing?

@WenMeng-NOAA
Copy link
Collaborator

@weihuang-jedi It seems to me #930, #932 and #937 were not synced yet. You might refer to the sync procedure here

@weihuang-jedi
Copy link
Contributor Author

I tried click "sync fork" button, and got:

upp fork

@WenMeng-NOAA
Copy link
Collaborator

@weihuang-jedi Please check your work branch 'wei-epic-aws' instead of 'develop'.

@weihuang-jedi
Copy link
Contributor Author

weihuang-jedi commented Apr 26, 2024 via email

@WenMeng-NOAA WenMeng-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label Apr 26, 2024
@WenMeng-NOAA
Copy link
Collaborator

@weihuang-jedi Now your branch looks good to me. Thanks for syncing.

@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs were completed on WCOSS2. There will be no baseline update in this PR. This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 88493f3 into NOAA-EMC:develop Apr 27, 2024
5 checks passed
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Apr 27, 2024
Closed
@weihuang-jedi weihuang-jedi deleted the wei-epic-aws branch April 27, 2024 04:28
zhanglikate added a commit to zhanglikate/UPP that referenced this pull request Apr 30, 2024
@zhanglikate
Squashed commit of the following:
7cf2fe3 
commit 13d5b6d
Author: EricJames-NOAA <[email protected]>
Date:   Mon Apr 29 15:28:47 2024 -0600

    RRFS updates (NOAA-EMC#938)

    * Initial commit to rename RRFS fix files, update EBB to be vertically integrated from 3D ebu_smoke, and switch to use 1-h average HWP.

    * Getting rid of vertically integrated hydrometeor fields.

    * Updating postxconfig-NT-rrfs.txt

commit 88493f3
Author: Wei Huang <[email protected]>
Date:   Fri Apr 26 21:29:51 2024 -0600

    add module for AWS (NOAA-EMC#934)

    * add module for AWS

    * comment that this is for NOAA Cloud

commit be0410e
Author: hsinmulin-NOAA <[email protected]>
Date:   Tue Apr 23 15:46:47 2024 -0400

    Add files via upload (NOAA-EMC#937)

    add
    1. 80 m for SPFH_ON_SPEC_HGT_LVL_ABOVE_GRND_FDHGT
    2. 80 m for PRES_ON_SPEC_HGT_LVL_ABOVE_GRND_FDHGT

commit 79d74d9
Author: Edward Hartnett <[email protected]>
Date:   Mon Apr 22 13:34:39 2024 -0600

    turn on doxygen build in CI (NOAA-EMC#932)

    * turn on doxygen build in CI

    * turn on doxygen build in CI

    * turn on doxygen build in CI

    * turn on doxygen build in CI

    * fixed cmake file

    * fixed doc directory

commit 5d6d179
Author: Dusan Jovic <[email protected]>
Date:   Fri Apr 19 14:17:10 2024 -0400

    Remove dependency on sfcio and use sigio only when nemsio is enabled (NOAA-EMC#930)

    * Remove sfcio and use sigio only when numsio is enabled

    * Remove sfcio from modulefiles/wcoss2.lua

    * Compile GFSPOSTSIG.F only if nemsio is enabled

commit 91921f4
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 15 21:04:39 2024 -0400

    Bump idna from 3.6 to 3.7 in /doc/UserGuide (NOAA-EMC#928)

    Bumps [idna](https://github.com/kjd/idna) from 3.6 to 3.7.
    - [Release notes](https://github.com/kjd/idna/releases)
    - [Changelog](https://github.com/kjd/idna/blob/master/HISTORY.rst)
    - [Commits](kjd/idna@v3.6...v3.7)

    ---
    updated-dependencies:
    - dependency-name: idna
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Wen Meng <[email protected]>

commit 8bc3fc9
Author: EricJames-NOAA <[email protected]>
Date:   Fri Apr 12 16:06:36 2024 -0600

    Bug fix for blowing snow effect on visibility (NOAA-EMC#915)

    * Correcting bug in CALVIS_GSD.f

    * Introducing roughness length impact on BLSN (no BLSN effect at z0>0.7).

    * Removing some gridpoint print statements for testing.

    * Checking change to compile_upp.sh

    * Reverting change.

commit fd93933
Author: YaliMao-NOAA <[email protected]>
Date:   Thu Apr 11 17:14:24 2024 +0000

    For RRFS, change the mnemonics of column max of EDPARM from EDPARM on 0m level to MXEDPRM of the entire atmosphere. (NOAA-EMC#926)

    For this purpose, MXEDPRM is added to both post_avblflds.xml and control file fv3lam_rrfs.xml

commit 5faac75
Author: WenMeng-NOAA <[email protected]>
Date:   Tue Apr 9 18:25:18 2024 -0400

    Correct total soil moisture from SOIMOI to CISOIM (NOAA-EMC#922)

    * Correct total soil moisture from SOIMOI to CISOIM

    * Update shortname of UPP ID 36

    * update CMake debug mode

commit 83e83a9
Author: Innocent Souopgui <[email protected]>
Date:   Fri Apr 5 15:10:14 2024 -0500

    Remove the detection of Jet/Centos7 nodes (NOAA-EMC#920)

    * Remove the detection of Jet/Centos7 nodes and removes the associated module file jet_c.lua

    * Update detect_machine.sh remove hera 12

    ---------

    Co-authored-by: Fernando Andrade - NOAA <[email protected]>

commit 1d1e58a
Author: Dusan Jovic <[email protected]>
Date:   Fri Apr 5 13:10:20 2024 -0400

    Add BUILD_WITH_NEMSIO build option to allow building UPP without nemsio (NOAA-EMC#911)

    * Add BUILD_WITH_NEMSIO build option to allow building UPP without nemsio

    * Specify w3emc and bacio as dependencies of nemsio library

    * Add compile_upp.sh option to build without nemsio (-n)

commit 7d39b5c
Author: WenMeng-NOAA <[email protected]>
Date:   Thu Apr 4 17:07:14 2024 -0400

    Add LTNG in PRSLEV dataset of RRFS (NOAA-EMC#918)

commit 62ecf8a
Author: AndrewBenjamin-NOAA <[email protected]>
Date:   Thu Apr 4 14:50:08 2024 -0400

    RRFSv1.0 Product cleanup: removal of retired products from fv3lam_rrfs.xml (NOAA-EMC#909)

    * removed  <table_info>NCEP</table_info> for ULWRF to use the official WMO ID rather than the dupilcate NCEP local use ID

    * removed <table_info>NCEP</table_info> from REFZR, REFZI, BMIXL, and CNWAT to use WMO grib2 ids

    * removed <table_info>NCEP</table_info> from SNOWC, SFEXC, SSRUN, BGRUN, FRICV, CD, SNOHF, PEVAP, TCOLI in order to use WMO id over NCEP local use ID.

    * removed <table_info>NCEP<table_info> from SNFALB, CDLYR, USWRF, DSWRF, DLWRF, VWSH, TCOLR, TCOLS, UPHL

    * removed <table_info>NCEP<table_info> from MSTAV in post_avblflds.xml to use WMO grib2 id for RRFS

    * removed duplicate CNWAT NATLEV entry in fv3lam_rrfs.xml.

    * updated fv3lam_rrfs.xml and parm/postxconfig-NT-fv3lam_rrfs.txt to remove products no longer needed in the RRFS.

    * changed precision in SSRUN

    * fixed SSRUN precision in flat file

    * removed LSPA and SNOWC from NATLEV

commit df9b16b
Author: EricJames-NOAA <[email protected]>
Date:   Mon Apr 1 15:51:56 2024 -0600

    Add surface albedo, accumulated snow melt, and total soil moisture output in RRFS (NOAA-EMC#908)

    * Updating CLDRAD and INITPOST_NETCDF

    * Reverting change in CLDRAD.f

    * Changes to output CISOILM and SNOM.

    * Cleaning up syntax.

    * Adding change logs.

    * Small updates.

    * Removing extcof55 from visibility calculation (it's all zeroes).

    * Reverting change in INITPOST_NETCDF.f setting smstot to spval

    * Using a single level "0 m underground" for CISOILM

commit 92b080d
Author: KarinaAsmar-NOAA <[email protected]>
Date:   Sat Mar 30 20:03:49 2024 -0400

    Add additional SFS variables and isobaric levels (NOAA-EMC#903)

    * added additional isobaric levels

    * adding HLCY, SSRUN, VBDSF

    * added HLCY, SSRUN, VBDSF

    * replacing id 772 with 401 and 403 (vbdsf and nbdsf)

    * vbdsf and nbdsf with info from avblflds

    * removed id 772 and added 401 and 403 (vbdsf and nbdsf)

    * vbdsf and nbdsf copied from gfs flux

    * vbdsf and nbdsf copied from gfs flux
@WenMeng-NOAA WenMeng-NOAA linked an issue May 6, 2024 that may be closed by this pull request
Needs add new module file to compile on AWS #933
Closed
DavidHuber-NOAA added a commit to DavidHuber-NOAA/UPP that referenced this pull request Sep 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into feature/ss_180
9669aba 
* origin/develop:
  Updates to support MPAS applications (RRFS and HFIP) (NOAA-EMC#1029)
  Add 6-hrly max winds at 10m to SFS (NOAA-EMC#1019)
  Update jet.lua (NOAA-EMC#1027)
  Updates to support UPP use with MPAS (NOAA-EMC#1018)
  [develop]: Turn on WARN_AS_ERROR for Doxygen Documentation Builds (NOAA-EMC#1023)
  Sample PR for testing (NOAA-EMC#1007)
  Enable template 4-49 to obtain aerosol ensemble information (NOAA-EMC#1011)
  Relocate gfs/gefs/sfs control files (NOAA-EMC#990)
  update g2tmp on aws to 1.12.0 (NOAA-EMC#996)
  [develop]: Update requirements files (NOAA-EMC#994)
  Bump zipp from 3.17.0 to 3.19.1 in /doc/UserGuide (NOAA-EMC#991)
  remove stack-python load for Gaea build (NOAA-EMC#993)
  Bump certifi from 2024.2.2 to 2024.7.4 in /doc/UserGuide (NOAA-EMC#988)
  [develop]: Add Doxygen variable definitions to modules (NOAA-EMC#965)
  Read bucket either as an integer or float (NOAA-EMC#984)
  Update Orion module file for Rocky 9 upgrade (NOAA-EMC#987)
  UPP bugfixes for inline post and g2tmpl 1.12.0 compatibility (and number concentration updates) (NOAA-EMC#974)
  Sync the RRFS hotfix NOAA-EMC#967 and NOAA-EMC#968. (NOAA-EMC#979)
  Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UserGuide (NOAA-EMC#981)
  Fix for hydrostatic runs - write out Omega and HGT from model output (NOAA-EMC#959)
  Bump requests from 2.31.0 to 2.32.0 in /doc/UserGuide (NOAA-EMC#963)
  Correct rt.sh paths (NOAA-EMC#957)
  Updates to use GRIB2 template 4.9 for QPFFFG and QPFARI variables in RRFS (NOAA-EMC#929)
  Add hourly averaged smoke PM2.5 and dust PM10 (NOAA-EMC#917)
  Update Namelist documentation for all namelist options (NOAA-EMC#940)
  update gtg code revision to v.4.16.3 (NOAA-EMC#954)
  Bump jinja2 from 3.1.3 to 3.1.4 in /doc/UserGuide (NOAA-EMC#953)
  Clean up labeling for 15-min accumulated fields (NOAA-EMC#948)
  Updates to the GSL exp1 ceiling diagnostic (NOAA-EMC#947)
  Additional RT log information (NOAA-EMC#941)
  add cmake load to modulefile/gaea.lua (NOAA-EMC#945)
  RRFS updates (NOAA-EMC#938)
  add module for AWS (NOAA-EMC#934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Needs add new module file to compile on AWS
3 participants
@weihuang-jedi @WenMeng-NOAA @aerorahul