-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to support MPAS applications (RRFS and HFIP) #1029
Conversation
(1) Determining dxval, dyval, dx(i,j), and dy(i,j) for applications using a lat-lon projection (2) Silencing several "sample" print statements
@jaymes-kenyon Can you open a UPP issue to link to this PR? |
@jaymes-kenyon Do you have MPAS-HFIP model output for my UPP standalone test? Would MPAS output you provided from last PR be sufficient for my test for RRFS-MPAS? |
Hi @WenMeng-NOAA — I've placed some HFIP-MPAS output on Hera, along with an "itag" file: For RRFS-MPAS testing, you may continue to use the sample from my previous PR. Thanks! |
@jaymes-kenyon Please validate my UPP standalone tests on Hera:
|
Hi @WenMeng-NOAA — Your tests look good to me—thanks for sharing! |
@jaymes-kenyon There seem to be an excessive number of printouts from INITPOST_MPAS.F. Could you reduce them?
|
@WenMeng-NOAA — Thanks! I commented-out several print statements in the most recent commit. In my test, this reduced the size of the UPP log file by about 20%. We can probably find many more "print" and "write" statements to comment-out going forward. |
@jaymes-kenyon For this print statement, I would suggest printing information exclusively from process 0 as:
|
@jaymes-kenyon I would suggest this printout come exclusively from process 0. |
@WenMeng-NOAA — Thanks for the advice; I added this logic to several "write" statements. |
@jaymes-kenyon I would suggest this type of printout (print*,***)in INITPOST_MPAS.F come exclusively from process 0. |
@jaymes-kenyon I would suggest the printout (write(,)) in getVariable.f come exclusively from process 0. |
Thanks, @WenMeng-NOAA — I will make another commit soon with these changes to INITPOST_MPAS and getVariable. Should I also modify the write statements in getIVariableN.f? It is very similar to getVariable.f |
@jaymes-kenyon It would be great if you apply the changes in getIVariableN.f. Thanks! |
@jaymes-kenyon The printouts in the runtime log have been reduced by more than 50%. Thanks for working on this. We will proceed with your PR for final testing. |
@FernandoAndrade-NOAA Please start the UPP RTs on R&D machines. There should be no baseline update. |
The UPP RTs have been completed on WCOSS2. No baseline update is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes in RT results across Hera, Hercules, and Orion.
This PR is ready for merging. |
* origin/develop: Updates to support MPAS applications (RRFS and HFIP) (NOAA-EMC#1029) Add 6-hrly max winds at 10m to SFS (NOAA-EMC#1019) Update jet.lua (NOAA-EMC#1027) Updates to support UPP use with MPAS (NOAA-EMC#1018) [develop]: Turn on WARN_AS_ERROR for Doxygen Documentation Builds (NOAA-EMC#1023) Sample PR for testing (NOAA-EMC#1007) Enable template 4-49 to obtain aerosol ensemble information (NOAA-EMC#1011) Relocate gfs/gefs/sfs control files (NOAA-EMC#990) update g2tmp on aws to 1.12.0 (NOAA-EMC#996) [develop]: Update requirements files (NOAA-EMC#994) Bump zipp from 3.17.0 to 3.19.1 in /doc/UserGuide (NOAA-EMC#991) remove stack-python load for Gaea build (NOAA-EMC#993) Bump certifi from 2024.2.2 to 2024.7.4 in /doc/UserGuide (NOAA-EMC#988) [develop]: Add Doxygen variable definitions to modules (NOAA-EMC#965) Read bucket either as an integer or float (NOAA-EMC#984) Update Orion module file for Rocky 9 upgrade (NOAA-EMC#987) UPP bugfixes for inline post and g2tmpl 1.12.0 compatibility (and number concentration updates) (NOAA-EMC#974) Sync the RRFS hotfix NOAA-EMC#967 and NOAA-EMC#968. (NOAA-EMC#979) Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UserGuide (NOAA-EMC#981) Fix for hydrostatic runs - write out Omega and HGT from model output (NOAA-EMC#959) Bump requests from 2.31.0 to 2.32.0 in /doc/UserGuide (NOAA-EMC#963) Correct rt.sh paths (NOAA-EMC#957) Updates to use GRIB2 template 4.9 for QPFFFG and QPFARI variables in RRFS (NOAA-EMC#929) Add hourly averaged smoke PM2.5 and dust PM10 (NOAA-EMC#917) Update Namelist documentation for all namelist options (NOAA-EMC#940) update gtg code revision to v.4.16.3 (NOAA-EMC#954) Bump jinja2 from 3.1.3 to 3.1.4 in /doc/UserGuide (NOAA-EMC#953) Clean up labeling for 15-min accumulated fields (NOAA-EMC#948) Updates to the GSL exp1 ceiling diagnostic (NOAA-EMC#947) Additional RT log information (NOAA-EMC#941) add cmake load to modulefile/gaea.lua (NOAA-EMC#945) RRFS updates (NOAA-EMC#938) add module for AWS (NOAA-EMC#934)
This PR provides several updates to improve UPP functionality with MPAS (specifically MPASSIT) output, including:
Testing has been successful in the HFIP-MPAS and RRFS-MPAS configurations, both of which use MPASSIT-generated netCDF output. This PR addresses issue #1030.