Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to support MPAS applications (RRFS and HFIP) #1029

Merged
merged 15 commits into from
Sep 6, 2024

Conversation

jaymes-kenyon
Copy link
Contributor

@jaymes-kenyon jaymes-kenyon commented Aug 29, 2024

This PR provides several updates to improve UPP functionality with MPAS (specifically MPASSIT) output, including:

  1. Changes in INITPOST_MPAS to handle lat–lon projections (as used in HFIP)
  2. Inclusion of SOILT and SOILW output
  3. Silencing various "sample" print statements

Testing has been successful in the HFIP-MPAS and RRFS-MPAS configurations, both of which use MPASSIT-generated netCDF output. This PR addresses issue #1030.

@jaymes-kenyon jaymes-kenyon changed the title Updates to support MPAS applications (RRFS and HFIP) [Draft] Updates to support MPAS applications (RRFS and HFIP) Aug 29, 2024
@jaymes-kenyon jaymes-kenyon changed the title [Draft] Updates to support MPAS applications (RRFS and HFIP) Updates to support MPAS applications (RRFS and HFIP) Aug 30, 2024
@jaymes-kenyon jaymes-kenyon marked this pull request as ready for review August 30, 2024 12:39
@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon Can you open a UPP issue to link to this PR?

@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Aug 30, 2024
@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon Do you have MPAS-HFIP model output for my UPP standalone test? Would MPAS output you provided from last PR be sufficient for my test for RRFS-MPAS?

@jaymes-kenyon
Copy link
Contributor Author

Hi @WenMeng-NOAA — I've placed some HFIP-MPAS output on Hera, along with an "itag" file:
/scratch2/BMC/wrfruc/kenyon/sample/hfip_mpas/2024080812
The intended UPP control file for HFIP-MPAS is postxconfig-NT-hfip.txt

For RRFS-MPAS testing, you may continue to use the sample from my previous PR. Thanks!

@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon Please validate my UPP standalone tests on Hera:

1) MPAS data: /home/Wen.Meng/stmp2/mpas_2024082112
2) MPAS_HFIP data: /home/Wen.Meng/stmp2/mpas_2024080900

@jaymes-kenyon
Copy link
Contributor Author

Hi @WenMeng-NOAA — Your tests look good to me—thanks for sharing!

@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon There seem to be an excessive number of printouts from INITPOST_MPAS.F. Could you reduce them?
e.g.

         if(i==im/2.and.j==(jsta+jend)/2)                           &
        print*,'i,j,L,ZINT from unipost= ',i,j,LM+1,ZINT(I,J,LM+1)      &
              , ALPINT(I,J,LM+1),ALPINT(I,J,LM)

@jaymes-kenyon
Copy link
Contributor Author

@WenMeng-NOAA — Thanks! I commented-out several print statements in the most recent commit. In my test, this reduced the size of the UPP log file by about 20%. We can probably find many more "print" and "write" statements to comment-out going forward.

@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon For this print statement, I would suggest printing information exclusively from process 0 as:

if (me==0) WRITE(6,*)'INITPOST_MPAS:  ENTER INITPOST_MPAS'

@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon I would suggest this printout come exclusively from process 0.

@jaymes-kenyon
Copy link
Contributor Author

@WenMeng-NOAA — Thanks for the advice; I added this logic to several "write" statements.

@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon I would suggest this type of printout (print*,***)in INITPOST_MPAS.F come exclusively from process 0.

@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon I would suggest the printout (write(,)) in getVariable.f come exclusively from process 0.
You may add process id "me" in this line.

@jaymes-kenyon
Copy link
Contributor Author

Thanks, @WenMeng-NOAA — I will make another commit soon with these changes to INITPOST_MPAS and getVariable. Should I also modify the write statements in getIVariableN.f? It is very similar to getVariable.f

@WenMeng-NOAA
Copy link
Collaborator

Thanks, @WenMeng-NOAA — I will make another commit soon with these changes to INITPOST_MPAS and getVariable. Should I also modify the write statements in getIVariableN.f? It is very similar to getVariable.f

@jaymes-kenyon It would be great if you apply the changes in getIVariableN.f. Thanks!

@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon The printouts in the runtime log have been reduced by more than 50%. Thanks for working on this. We will proceed with your PR for final testing.

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA Please start the UPP RTs on R&D machines. There should be no baseline update.

@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs have been completed on WCOSS2. No baseline update is needed.

@WenMeng-NOAA WenMeng-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label Sep 6, 2024
Copy link
Collaborator

@FernandoAndrade-NOAA FernandoAndrade-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes in RT results across Hera, Hercules, and Orion.

@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit de75068 into NOAA-EMC:develop Sep 6, 2024
3 checks passed
DavidHuber-NOAA added a commit to DavidHuber-NOAA/UPP that referenced this pull request Sep 9, 2024
* origin/develop:
  Updates to support MPAS applications (RRFS and HFIP) (NOAA-EMC#1029)
  Add 6-hrly max winds at 10m to SFS (NOAA-EMC#1019)
  Update jet.lua (NOAA-EMC#1027)
  Updates to support UPP use with MPAS (NOAA-EMC#1018)
  [develop]: Turn on WARN_AS_ERROR for Doxygen Documentation Builds (NOAA-EMC#1023)
  Sample PR for testing (NOAA-EMC#1007)
  Enable template 4-49 to obtain aerosol ensemble information (NOAA-EMC#1011)
  Relocate gfs/gefs/sfs control files (NOAA-EMC#990)
  update g2tmp on aws to 1.12.0 (NOAA-EMC#996)
  [develop]: Update requirements files (NOAA-EMC#994)
  Bump zipp from 3.17.0 to 3.19.1 in /doc/UserGuide (NOAA-EMC#991)
  remove stack-python load for Gaea build (NOAA-EMC#993)
  Bump certifi from 2024.2.2 to 2024.7.4 in /doc/UserGuide (NOAA-EMC#988)
  [develop]: Add Doxygen variable definitions to modules (NOAA-EMC#965)
  Read bucket either as an integer or float (NOAA-EMC#984)
  Update Orion module file for Rocky 9 upgrade (NOAA-EMC#987)
  UPP bugfixes for inline post and g2tmpl 1.12.0 compatibility (and number concentration updates) (NOAA-EMC#974)
  Sync the RRFS hotfix NOAA-EMC#967 and NOAA-EMC#968. (NOAA-EMC#979)
  Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UserGuide (NOAA-EMC#981)
  Fix for hydrostatic runs - write out Omega and HGT from model output (NOAA-EMC#959)
  Bump requests from 2.31.0 to 2.32.0 in /doc/UserGuide (NOAA-EMC#963)
  Correct rt.sh paths (NOAA-EMC#957)
  Updates to use GRIB2 template 4.9 for QPFFFG and QPFARI variables in RRFS (NOAA-EMC#929)
  Add hourly averaged smoke PM2.5 and dust PM10 (NOAA-EMC#917)
  Update Namelist documentation for all namelist options (NOAA-EMC#940)
  update gtg code revision to v.4.16.3 (NOAA-EMC#954)
  Bump jinja2 from 3.1.3 to 3.1.4 in /doc/UserGuide (NOAA-EMC#953)
  Clean up labeling for 15-min accumulated fields (NOAA-EMC#948)
  Updates to the GSL exp1 ceiling diagnostic (NOAA-EMC#947)
  Additional RT log information (NOAA-EMC#941)
  add cmake load to modulefile/gaea.lua (NOAA-EMC#945)
  RRFS updates (NOAA-EMC#938)
  add module for AWS (NOAA-EMC#934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MPAS No Baseline Change No baseline of the UPP regression tests are made. Ready for commit queue Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPAS applications: add processing for lat–lon projection, add soil fields (TSOIL, SOILW)
3 participants