Updating the UPP hash #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymes-kenyon
requested review from
MatthewPyle-NOAA,
ShunLiu-NOAA,
JacobCarley-NOAA and
BenjaminBlake-NOAA
as code owners
MatthewPyle-NOAA
approved these changes
May 3, 2024
This was referenced May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
This updates the hash for UPP code. With this hash, the latest refinements to the GSL "exp1" ceiling diagnostic are used.
Note that this PR simply changes the "exp1" ceiling formulation. It does not affect the formulation or the availability of the other ceiling-related fields in RRFS (i.e., the legacy field and the "exp2" field).
TESTS CONDUCTED:
This change has been tested in a RRFS retro (1–3 Feb 2022; CONUS domain) on Hera.
Machines/Platforms:
Test cases:
ISSUE:
The associated PR for UPP can be viewed at NOAA-EMC/UPP#947