Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InventoryCollection Builder #17396

Closed
33 tasks done
slemrmartin opened this issue May 9, 2018 · 3 comments
Closed
33 tasks done

InventoryCollection Builder #17396

slemrmartin opened this issue May 9, 2018 · 3 comments
Labels
providers/inventory refactoring

Comments

@slemrmartin
Copy link
Contributor

slemrmartin commented May 9, 2018 •
edited
Loading

New Interface for definition/creating InventoryCollection from persister (ManagerRefresh::Inventory::Persister and its provider specific subclasses)
Accessible via add_collection() method

Intended to replace:

add_inventory_collection() method
has_inventory() method
Classes ManagerRefresh::InventoryCollection::Builder and descendants can replace:

ManagerRefresh::InventoryCollectionDefault and subclasses (using add_inventory_collection interface)
ManagerRefresh::Inventory::Core module (and classes including it - using has_inventory() interface)
IC model class is derived from persister class and IC association value
IC inventory_object_attributes are derived from setters of model_class
IC parent added automatically if missing
(all can be disabled by settings)

Documentation:
https://github.com/ManageIQ/guides/blob/master/providers/persister/inventory_collections.md
ManageIQ/guides#316

Pull requests:

Optimizations:

Final cleanup
(depends on all previous PRs)
This was referenced May 9, 2018
Merged
Merged
Merged
Merged
Merged
Merged
@slemrmartin slemrmartin mentioned this issue May 24, 2018
Merged
2 tasks
This was referenced Jun 12, 2018
Merged
Merged
Merged
Merged
@slemrmartin
Copy link
Contributor Author

@miq-bot add_label providers/inventory
@miq-bot add_label refactoring

slemrmartin added a commit to slemrmartin/guides that referenced this issue Jun 19, 2018
@slemrmartin
InventoryCollection definition doc
7436cd2 
Issue ManageIQ/manageiq#17396
This was referenced Jun 19, 2018
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jul 2, 2018
Merged
Merged
Merged
Merged
@slemrmartin slemrmartin mentioned this issue Jul 9, 2018
Merged
This was referenced Jul 19, 2018
Merged
Merged
This was referenced Jul 20, 2018
Merged
Merged
Merged
Merged
@jameswnl jameswnl mentioned this issue Jul 25, 2018
Closed
@slemrmartin slemrmartin mentioned this issue Aug 1, 2018
Merged
@slemrmartin slemrmartin reopened this Aug 8, 2018
@JPrause
Copy link
Member

JPrause commented Nov 21, 2018

@slemrmartin is this still an open issue? If not, can you close it.

@slemrmartin
Copy link
Contributor Author

it's complete, @JPrause, closing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
providers/inventory refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@slemrmartin @miq-bot @JPrause