Persister: InventoryCollection building through add_collection() #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
slemrmartin
force-pushed
the
inventory-collection-builder
branch
2 times, most recently
from
fc0b14b to
4174dc7
Compare
|
This pull request is not mergeable. Please rebase and repush. |
|
@slemrmartin when possible please try to rebase rather than creating merge commits |
7 tasks
slemrmartin
force-pushed
the
inventory-collection-builder
branch
from
bd4da03 to
e8b111a
Compare
2 tasks
Persister's add_collection() interface
Due to dependencies from ovirt, where auto deriving model_class is not compatible
Methods with class names unified across providers
slemrmartin
force-pushed
the
inventory-collection-builder
branch
from
e8b111a to
b7e7229
Compare
|
@miq-bot add_label refactoring |
|
Checked commits slemrmartin/manageiq-providers-openstack@dbcecf4~...b7e7229 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
slemrmartin
changed the title
agrare
approved these changes
Jun 14, 2018
agrare
added a commit
that referenced
this pull request
Jun 14, 2018
Persister: InventoryCollection building through add_collection()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: ManageIQ/manageiq#17396
New Interface for definition/creating InventoryCollection from persister.
Using add_collection() instead of add_inventory_collection() to build collections.
Builder classes are defined on core project, provider specific InventoryCollections specified in concerns