Persister: InventoryCollection building through add_collection() #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slemrmartin
force-pushed
the
inventory-collection-builder
branch
from
617e59d to
9ace759
Compare
This was referenced May 24, 2018
|
This pull request is not mergeable. Please rebase and repush. |
|
note: unmergeable by #244 |
Persister's add_collection() interface
Methods with class names unified across providers
To fit global definition in core
slemrmartin
force-pushed
the
inventory-collection-builder
branch
from
5e9fc5c to
afb2190
Compare
slemrmartin
commented
Jun 12, 2018
| def initialize_infra_inventory_collections | ||
| @collection_group = nil | ||
|
|
||
| add_collection(infra, :ems_folders) |
from ManageIQ#244. And rename IC folder Shared -> Definitions
slemrmartin
force-pushed
the
inventory-collection-builder
branch
from
afb2190 to
2763e2b
Compare
|
Checked commits slemrmartin/manageiq-providers-ovirt@e517a36~...2763e2b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
slemrmartin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: ManageIQ/manageiq#17396
New Interface for definition/creating InventoryCollection from persister.
Using add_collection() instead of add_inventory_collection() to build collections.
Builder classes are defined on core project, provider specific InventoryCollections specified in concerns