Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InventoryCollection builder_params -> default_values #281

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

slemrmartin
Copy link
Contributor

@slemrmartin slemrmartin commented Jul 23, 2018

Issue: ManageIQ/manageiq#17396

Removing "builder_params" term from all inventory_collection related classes

@miq-bot
Copy link
Member

miq-bot commented Jul 24, 2018

Checked commit slemrmartin@f34a2d6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@slemrmartin slemrmartin changed the title [WIP] InventoryCollection builder_params -> default_values InventoryCollection builder_params -> default_values Jul 25, 2018
@slemrmartin
Copy link
Contributor Author

cc @agrare

@miq-bot miq-bot removed the wip label Jul 25, 2018
@agrare agrare self-assigned this Jul 25, 2018
@agrare agrare added the cleanup label Jul 25, 2018
@agrare agrare closed this Jul 25, 2018
@agrare agrare reopened this Jul 25, 2018
@agrare agrare merged commit f34a2d6 into ManageIQ:master Jul 25, 2018
agrare added a commit that referenced this pull request Jul 25, 2018
InventoryCollection builder_params -> default_values
@agrare agrare added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 25, 2018
@slemrmartin slemrmartin deleted the ic-builder-builder-params branch July 26, 2018 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants