Persister: InventoryCollection building through add_collection() (Infra) #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2018
switching from old interface for IC definitions
slemrmartin
force-pushed
the
ic-builder-infra
branch
from
0b00342 to
2360e65
Compare
For InfraManager's persister
Ovirt added incompatible parent_iventory_collections property to core
slemrmartin
commented
Jul 20, 2018
| end | ||
| end | ||
|
|
||
| def add_host_guest_devices |
There was a problem hiding this comment.
@agrare moved to core in your PR https://github.com/ManageIQ/manageiq/pull/17505/files#diff-be0179ddb233d59fa266cfa25e271345R27
So I'll wait for merge of it
slemrmartin
commented
Jul 20, 2018
| end | ||
| end | ||
|
|
||
| def add_host_system_services |
There was a problem hiding this comment.
@agrare can I move this one to core too? ..or can you add it to your PR (mentioned above)?
There was a problem hiding this comment.
@slemrmartin 👍 I'll add it to my PR
under Inventory dir
|
Checked commits slemrmartin/manageiq-providers-vmware@2360e65~...3d7d704 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Cc @Ladas |
agrare
approved these changes
Jul 20, 2018
agrare
added a commit
that referenced
this pull request
Jul 20, 2018
Persister: InventoryCollection building through add_collection() (Infra)
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
…figration_namespace Created new namespace for Configuration/Email.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: ManageIQ/manageiq#17396
New Interface for definition/creating InventoryCollection from persister.
Using add_collection() instead of add_inventory_collection() to build collections.
This PR refactors persister for Infra manager.
Builder classes are defined on core project, provider specific InventoryCollections specified in concerns
Cc @agrare