Persister: InventoryCollection building through add_collection() #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Persister's add_collection() interface
This was referenced Jul 2, 2018
slemrmartin
force-pushed
the
inventory-collection-builder
branch
from
983499a to
3e8ba59
Compare
ContainerContition, Tagging and CustomAttribute
slemrmartin
force-pushed
the
inventory-collection-builder
branch
from
3e8ba59 to
118b840
Compare
|
Wow impressive global effort 👏 TBH I no longer remember much about this part :) cc @Ladas @agrare who maybe remember more. |
|
Checked commits slemrmartin/manageiq-providers-kubernetes@c6c56a9~...6dbb06d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
This was referenced Jul 4, 2018
agrare
approved these changes
Jul 11, 2018
agrare
added a commit
that referenced
this pull request
Jul 11, 2018
Persister: InventoryCollection building through add_collection()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: ManageIQ/manageiq#17396
(depends on) PR: InventoryCollection Builder improvements manageiq#17621
dependent: Persister: InventoryCollection building through add_collection() manageiq-providers-openshift#100
New Interface for definition/creating InventoryCollection from persister.
Using add_collection() instead of add_inventory_collection() to build collections.
Builder classes are defined on core project, provider specific InventoryCollections specified in concerns