Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Automate Methods to new style using classes #12038

Closed
mkanoor opened this issue Oct 18, 2016 · 1 comment
Closed

Convert Automate Methods to new style using classes #12038

mkanoor opened this issue Oct 18, 2016 · 1 comment
Assignees
@gmcculloug
Labels
automate/model

Comments

@mkanoor
Copy link
Contributor

mkanoor commented Oct 18, 2016 •
edited
Loading

Convert the Automate methods to new style using classes to facilitate testing outside the Automate Engine.

Notes:

  1. Each method needs to have a corresponding spec using the same path as the method file.
  2. Most of the methods can be tested outside of the Automate Engine using
    • Mock Service
    • Mock Objects
  3. The methods should not have an exit call since that exits RSpec.
  4. As each method is converted we should check the box next to the item
  5. Look for methods which might be the same in Cloud and Infrastructure namespaces.
  6. @billfitzgerald0120 is working on consolidating the email methods so we should check with him before converting email methods.
  7. Why is this necessary
if __FILE__ == $PROGRAM_NAME
  MyMethodClass.new.main
end

This idea is borrowed from Python, which allows us to source in the file without executing any code. The if block gets executed only when we directly pass in the file to the ruby interpreter. When we test the method script we source in the file in the spec and then instantiate it for testing, it allows us to pass in a mock service for testing.

Good sample of a method
https://github.com/ManageIQ/manageiq/blob/master/db/fixtures/ae_datastore/ManageIQ/Cloud/Orchestration/Operations/Methods.class/__methods__/available_availability_zones.rb
Good sample of a spec
https://github.com/ManageIQ/manageiq/blob/master/spec/db/fixtures/ae_datastore/ManageIQ/Cloud/Orchestration/Operations/Methods.class/__methods__/available_availability_zones_spec.rb

The methods have been categorized based on different lifecycle's

  1. Provisioning
  2. Retirement
  3. Reconfigure/Reconfiguration
  4. Operations
  5. Migrate

ManageIQ/Cloud/Orchestration/Operations

ManageIQ/Cloud/Orchestration/Provisioning

ManageIQ/Cloud/Orchestration/Reconfiguration

  • /Email.class/methods/servicereconfigure_complete.rb
  • /Email.class/methods/servicereconfigurerequest_approved.rb
  • /StateMachines/Methods.class/methods/check_reconfigured.rb
  • /StateMachines/Methods.class/methods/postreconfigure.rb
  • /StateMachines/Methods.class/methods/prereconfigure.rb
  • /StateMachines/Methods.class/methods/reconfigure.rb
  • /StateMachines/Reconfigure.class/methods/update_servicereconfigure_status.rb

ManageIQ/Cloud/Orchestration/Retirement

  • /Email.class/methods/stack_retirement_emails.rb
  • /StateMachines/Methods.class/methods/check_removed_from_provider.rb
  • /StateMachines/Methods.class/methods/delete_from_vmdb.rb
  • /StateMachines/Methods.class/methods/finish_retirement.rb
  • /StateMachines/Methods.class/methods/remove_from_provider.rb
  • /StateMachines/Methods.class/methods/start_retirement.rb
  • /StateMachines/StackRetirement.class/methods/update_retirement_status.rb

ManageIQ/Cloud/VM/Provisioning

  • /Email.class/methods/miqprovision_complete.rb
  • /Email.class/methods/miqprovisionrequest_approved.rb
  • /Email.class/methods/miqprovisionrequest_denied.rb
  • /Email.class/methods/miqprovisionrequest_pending.rb
  • /Naming.class/methods/vmname.rb
  • /Placement.class/methods/best_fit_amazon.rb
  • /Placement.class/methods/best_fit_azure.rb
  • /Placement.class/methods/best_fit_google.rb
  • /Placement.class/methods/best_fit_openstack.rb
  • /Profile.class/methods/get_deploy_dialog.rb
  • /Profile.class/methods/vm_dialog_name_prefix.rb
  • /StateMachines/Methods.class/methods/amazon_customizerequest.rb
  • /StateMachines/Methods.class/methods/amazon_postprovision.rb
  • /StateMachines/Methods.class/methods/amazon_preprovision.rb
  • /StateMachines/Methods.class/methods/amazon_preprovision_clone_to_vm.rb
  • /StateMachines/Methods.class/methods/check_provisioned.rb
  • /StateMachines/Methods.class/methods/openstack_customizerequest.rb
  • /StateMachines/Methods.class/methods/openstack_postprovision.rb
  • /StateMachines/Methods.class/methods/openstack_preprovision.rb
  • /StateMachines/Methods.class/methods/openstack_preprovision_clone_to_vm.rb
  • /StateMachines/Methods.class/methods/postprovision.rb
  • /StateMachines/Methods.class/methods/preprovision.rb
  • /StateMachines/Methods.class/methods/provision.rb
  • /StateMachines/Methods.class/methods/scan.rb
  • /StateMachines/ProvisionRequestApproval.class/methods/approve_request.rb
  • /StateMachines/ProvisionRequestApproval.class/methods/pending_request.rb
  • /StateMachines/ProvisionRequestApproval.class/methods/validate_request.rb
  • /StateMachines/ProvisionRequestQuotaVerification.class/methods/rejected.rb
  • /StateMachines/ProvisionRequestQuotaVerification.class/methods/validate_quotas.rb
  • /StateMachines/VMProvision_VM.class/methods/update_provision_status.rb

ManageIQ/Cloud/VM/Retirement

  • /Email.class/methods/vm_retire_extend.rb
  • /Email.class/methods/vm_retirement_emails.rb
  • /StateMachines/Methods.class/methods/amazon_check_pre_retirement.rb
  • /StateMachines/Methods.class/methods/amazon_pre_retirement.rb
  • /StateMachines/Methods.class/methods/check_deleted_from_provider.rb
  • /StateMachines/Methods.class/methods/check_powered_off.rb
  • /StateMachines/Methods.class/methods/check_pre_retirement.rb
  • /StateMachines/Methods.class/methods/check_removed_from_provider.rb
  • /StateMachines/Methods.class/methods/delete_from_vmdb.rb
  • /StateMachines/Methods.class/methods/finish_retirement.rb
  • /StateMachines/Methods.class/methods/openstack_pre_retirement.rb
  • /StateMachines/Methods.class/methods/pre_retirement.rb
  • /StateMachines/Methods.class/methods/remove_from_provider.rb
  • /StateMachines/Methods.class/methods/start_retirement.rb
  • /StateMachines/VMRetirement.class/methods/update_retirement_status.rb

ManageIQ/ConfigurationManagement/AnsibleTower/Operations

ManageIQ/ConfigurationManagement/AnsibleTower/Service/Provisioning

  • /Email.class/methods/serviceprovision_complete.rb
  • /Email.class/methods/servicetemplateprovisionrequest_approved.rb
  • /StateMachines/Provision.class/methods/check_provisioned.rb
  • /StateMachines/Provision.class/methods/post_provision.rb
  • /StateMachines/Provision.class/methods/preprovision.rb
  • /StateMachines/Provision.class/methods/provision.rb
  • /StateMachines/Provision.class/methods/update_serviceprovision_status.rb

ManageIQ/Control/

  • /Email.class/methods/ems_cluster_alert.rb
  • /Email.class/methods/ext_management_system_alert.rb
  • /Email.class/methods/host_alert.rb
  • /Email.class/methods/miq_server_alert.rb
  • /Email.class/methods/parse_alerts.rb
  • /Email.class/methods/storage_alert.rb
  • /Email.class/methods/vm_alert.rb

ManageIQ/Deployment/ContainerProvider/System/

  • /StateMachine/Deployment.class/methods/add_provider.rb
  • /StateMachine/Deployment.class/methods/analyze_deployment.rb
  • StateMachine/Deployment.class/methods/check_ssh.rb
  • /StateMachine/Deployment.class/methods/cleanup.rb
  • /StateMachine/Deployment.class/methods/deployment.rb
  • /StateMachine/Deployment.class/methods/post_provision.rb
  • /StateMachine/Deployment.class/methods/pre_deployment.rb
  • /StateMachine/Deployment.class/methods/pre_validate.rb
  • /StateMachine/Deployment.class/methods/provision.rb

ManageIQ/Infrastructure/Cluster/Operations

  • /Methods.class/methods/cluster_workload_management.rb

ManageIQ/Infrastructure/Configured_System/Provisioning

  • /Email.class/methods/provision_complete.rb
  • /Email.class/methods/request_approved.rb
  • /StateMachines/Methods.class/methods/check_provisioned.rb
  • /StateMachines/Methods.class/methods/preprovision.rb
  • /StateMachines/Methods.class/methods/provision.rb
  • /StateMachines/Provision.class/methods/update_provision_status.rb
  • /StateMachines/ProvisionRequestApproval.class/methods/approve_request.rb
  • /StateMachines/ProvisionRequestApproval.class/methods/pending_request.rb
  • /StateMachines/ProvisionRequestApproval.class/methods/validate_request.rb
  • /StateMachines/ProvisionRequestQuotaVerification.class/methods/rejected.rb
  • /StateMachines/ProvisionRequestQuotaVerification.class/methods/validate_quotas.rb

ManageIQ/Infrastructure/Host/Operations

  • /Methods.class/methods/host_evacuation.rb

ManageIQ/Infrastructure/Host/Provisioning

  • /Email.class/methods/miqhostprovision_complete.rb
  • /Email.class/methods/miqhostprovisionrequest_approved.rb
  • /Profile.class/methods/get_deploy_dialog.rb
  • /StateMachines/HostProvision.class/methods/update_provision_status.rb
  • /StateMachines/Methods.class/methods/check_provisioned.rb
  • /StateMachines/Methods.class/methods/customizerequest.rb
  • /StateMachines/Methods.class/methods/postprovision_host.rb
  • /StateMachines/Methods.class/methods/preprovision_host.rb
  • /StateMachines/Methods.class/methods/provision.rb

ManageIQ/Infrastructure/VM/Migrate

  • /Email.class/methods/vmmigraterequest_approved.rb
  • /Email.class/methods/vmmigratetask_complete.rb
  • /Profile.class/methods/get_deploy_dialog.rb
  • /StateMachines/Methods.class/methods/besthost.rb
  • /StateMachines/Methods.class/methods/beststorage.rb
  • /StateMachines/Methods.class/methods/checkmigration.rb
  • /StateMachines/Methods.class/methods/migrate.rb
  • /StateMachines/Methods.class/methods/postmigration.rb
  • /StateMachines/Methods.class/methods/premigration.rb
  • /StateMachines/VMMigrate.class/methods/update_migration_status.rb

ManageIQ/Infrastructure/VM/Operations

  • /Methods.class/methods/vm_placement_optimization.rb

ManageIQ/Infrastructure/VM/Provisioning

  • /Email.class/methods/miqprovision_complete.rb
  • /Email.class/methods/miqprovisionrequest_approved.rb
  • /Email.class/methods/miqprovisionrequest_denied.rb
  • /Email.class/methods/miqprovisionrequest_pending.rb
  • /Naming.class/methods/vmname.rb
  • /Placement.class/methods/microsoft_best_fit_least_utilized.rb
  • /Placement.class/methods/redhat_best_fit_cluster.rb
  • /Placement.class/methods/vmware_best_fit_least_utilized.rb
  • /Profile.class/methods/get_deploy_dialog.rb
  • /Profile.class/methods/vm_dialog_name_prefix.rb
  • /StateMachines/Methods.class/methods/check_provisioned.rb
  • /StateMachines/Methods.class/methods/provision.rb
  • /StateMachines/Methods.class/methods/redhat_customizerequest.rb
  • /StateMachines/Methods.class/methods/redhat_postprovision.rb
  • /StateMachines/Methods.class/methods/redhat_preprovision.rb
  • /StateMachines/Methods.class/methods/redhat_preprovision_clone_to_template.rb
  • /StateMachines/Methods.class/methods/redhat_preprovision_clone_to_vm.rb
  • /StateMachines/Methods.class/methods/scan.rb
  • /StateMachines/Methods.class/methods/vmware_customizerequest.rb
  • /StateMachines/Methods.class/methods/vmware_postprovision.rb
  • /StateMachines/Methods.class/methods/vmware_preprovision.rb
  • /StateMachines/Methods.class/methods/vmware_preprovision_clone_to_template.rb
  • /StateMachines/Methods.class/methods/vmware_preprovision_clone_to_vm.rb
  • /StateMachines/ProvisionRequestApproval.class/methods/approve_request.rb
  • /StateMachines/ProvisionRequestApproval.class/methods/pending_request.rb
  • /StateMachines/ProvisionRequestApproval.class/methods/validate_request.rb
  • /StateMachines/ProvisionRequestQuotaVerification.class/methods/rejected.rb
  • /StateMachines/ProvisionRequestQuotaVerification.class/methods/validate_quotas.rb
  • /StateMachines/VMProvision_Template.class/methods/update_provision_status.rb
  • /StateMachines/VMProvision_VM.class/methods/update_provision_status.rb

ManageIQ/Infrastructure/VM/Reconfigure

  • /Email.class/methods/vmreconfigure_request_approved.rb
  • /Email.class/methods/vmreconfigure_task_complete.rb

ManageIQ/Infrastructure/VM/Retirement

  • /Email.class/methods/vm_retire_extend.rb
  • /Email.class/methods/vm_retirement_emails.rb
  • /StateMachines/Methods.class/methods/check_powered_off.rb
  • /StateMachines/Methods.class/methods/check_pre_retirement.rb
  • /StateMachines/Methods.class/methods/check_removed_from_provider.rb
  • /StateMachines/Methods.class/methods/delete_from_vmdb.rb
  • /StateMachines/Methods.class/methods/finish_retirement.rb
  • /StateMachines/Methods.class/methods/power_off.rb
  • /StateMachines/Methods.class/methods/pre_retirement.rb
  • /StateMachines/Methods.class/methods/remove_from_provider.rb
  • /StateMachines/Methods.class/methods/start_retirement.rb
  • /StateMachines/VMRetirement.class/methods/update_retirement_status.rb

ManageIQ/Service/Provisioning/

  • /Email.class/methods/serviceprovision_complete.rb
  • /Email.class/methods/servicetemplateprovisionrequest_approved.rb
  • /Email.class/methods/servicetemplateprovisionrequest_denied.rb
  • /Email.class/methods/servicetemplateprovisionrequest_pending.rb
  • /Email.class/methods/servicetemplateprovisionrequest_warning.rb
  • /ServiceFilter.class/methods/filterbydialogparameters.rb
  • /StateMachines/Methods.class/methods/catalogbundleinitialization.rb
  • /StateMachines/Methods.class/methods/catalogiteminitialization.rb
  • /StateMachines/Methods.class/methods/check_provisioned.rb
  • /StateMachines/Methods.class/methods/dialog_parser.rb
  • /StateMachines/Methods.class/methods/groupsequencecheck.rb
  • /StateMachines/Methods.class/methods/provision.rb
  • /StateMachines/Methods.class/methods/statemachine_finished.rb
  • /StateMachines/ServiceProvisionRequestApproval.class/methods/approve_request.rb
  • /StateMachines/ServiceProvisionRequestApproval.class/methods/pending_request.rb
  • /StateMachines/ServiceProvisionRequestApproval.class/methods/validate_request.rb
  • /StateMachines/ServiceProvision_Template.class/methods/update_serviceprovision_status.rb

ManageIQ/Service/Retirement

  • /StateMachines/Methods.class/methods/check_service_retired.rb
  • /StateMachines/Methods.class/methods/delete_service_from_vmdb.rb
  • /StateMachines/Methods.class/methods/finish_retirement.rb
  • /StateMachines/Methods.class/methods/get_retirement_entrypoint.rb
  • /StateMachines/Methods.class/methods/mark_service_as_retired.rb
  • /StateMachines/Methods.class/methods/retire_service.rb
  • /StateMachines/Methods.class/methods/start_retirement.rb
  • /StateMachines/ServiceRetirement.class/methods/update_service_retirement_status.rb

ManageIQ/System

  • /CommonMethods/QuotaMethods.class/methods/limits.rb
  • /CommonMethods/QuotaMethods.class/methods/quota_source.rb
  • /CommonMethods/QuotaMethods.class/methods/requested.rb
  • /CommonMethods/QuotaMethods.class/methods/used.rb
  • /CommonMethods/QuotaMethods.class/methods/validate_quota.rb
  • /CommonMethods/QuotaStateMachine.class/methods/rejected.rb
  • /CommonMethods/StateMachineMethods.class/methods/task_finished.rb
  • /Policy.class/methods/get_request_type.rb
  • /Policy.class/methods/miqhostprovision_auto_approve.rb
  • /Policy.class/methods/vmmigraterequest_auto_approve.rb
  • /Policy.class/methods/vmreconfigure_request_auto_approve.rb
  • /Request.class/methods/inspectme.rb
This was referenced Oct 24, 2016
Merged
Merged
Merged
Merged
@pkomanek pkomanek mentioned this issue Nov 9, 2016
Merged
This was referenced Nov 17, 2016
Merged
Merged
This was referenced Dec 13, 2016
Merged
Merged
@mkanoor
Copy link
Contributor Author

mkanoor commented Dec 19, 2016

Closed in favor of ManageIQ/manageiq-content#8

@mkanoor mkanoor closed this as completed Dec 19, 2016
This was referenced Jan 19, 2017
Merged
Merged
@billfitzgerald0120 billfitzgerald0120 mentioned this issue May 2, 2017
Merged
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue May 11, 2017
@billfitzgerald0120
Refactor infra vm check_remove_from_provider method and test.
f3d305d 
Refactored the check_remove_from_provider method for Infrastructure Vm retirement.
Updated tests.

This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@billfitzgerald0120 billfitzgerald0120 mentioned this issue May 11, 2017
Merged
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue May 11, 2017
@billfitzgerald0120
Refactor infra vm check_remove_from_provider method and test.
ac7cafc 
Refactored the check_remove_from_provider method for Infrastructure Vm retirement.
Updated tests.

This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue May 11, 2017
@billfitzgerald0120
Refactor infra vm check_remove_from_provider method and test.
32391f6 
Refactored the check_remove_from_provider method for Infrastructure Vm retirement.
Updated tests.

This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue May 12, 2017
@billfitzgerald0120
Refactor infra vm check_remove_from_provider method and test.
03a032e 
Refactored the check_remove_from_provider method for Infrastructure Vm retirement.
Updated tests.

This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue May 12, 2017
@billfitzgerald0120
Refactor infra vm check_remove_from_provider method and test.
fd31958 
Refactored the check_remove_from_provider method for Infrastructure Vm retirement.
Updated tests.

This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
lfu pushed a commit to lfu/manageiq-content that referenced this issue May 22, 2017
@billfitzgerald0120 @lfu
Refactor infra vm check_remove_from_provider method and test.
8de08f8 
Refactored the check_remove_from_provider method for Infrastructure Vm retirement.
Updated tests.

This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Oct 4, 2017
@billfitzgerald0120
Refactor used quota method and test
67e73c3 
This PR is based on on the issue below.
ManageIQ/manageiq#12038
@billfitzgerald0120 billfitzgerald0120 mentioned this issue Oct 4, 2017
Merged
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Oct 4, 2017
@billfitzgerald0120
Refactor used quota method and test
aa1ebe3 
This PR is based on on the issue below.
ManageIQ/manageiq#12038
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Oct 5, 2017
@billfitzgerald0120
Refactor used quota method and test
9cd896a 
This PR is based on on the issue below.
ManageIQ/manageiq#12038
@GregP GregP mentioned this issue Sep 18, 2019
Closed
@GregP GregP mentioned this issue Oct 1, 2019
Merged
@GregP GregP mentioned this issue Oct 18, 2019
Merged
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Nov 12, 2019
@billfitzgerald0120
Refactor start_retirement method for Service Retirement.
56623d7 
This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz

Added test for service_retire_task = nil, was missing this in coverage
Added test for retirement_state = 'retiring' as requested
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Nov 12, 2019
@billfitzgerald0120
Refactor start_retirement method for Infra VM Retirement.
79d3e6b 
This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz
Added test for retirement_start eq retiring as requested
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Nov 13, 2019
@billfitzgerald0120
Refactor start_retirement method for Service Retirement.
2cc5c53 
This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz

Added test for service_retire_task = nil, was missing this in coverage
Added test for retirement_state = 'retiring' as requested

Modified method as requested
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Nov 13, 2019
@billfitzgerald0120
Refactor start_retirement method for Service Retirement.
f90436c 
This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz

Added test for service_retire_task = nil, was missing this in coverage
Added test for retirement_state = 'retiring' as requested

Modified method as requested
Deleted comment and blank line
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Nov 13, 2019
@billfitzgerald0120
Refactor finish_retirement method for Service Retirement.
2b526ef 
This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz

Added test for retirement_state equal 'retired'
Changed to use a service method
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Nov 13, 2019
@billfitzgerald0120
Refactor start_retirement method for Service Retirement.
025b13b 
This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz

Added test for service_retire_task = nil, was missing this in coverage
Added test for retirement_state = 'retiring' as requested

Modified method as requested
Deleted comment and blank line
Removed extra log messages because Raise doesn't need them
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Nov 13, 2019
@billfitzgerald0120
Refactor finish_retirement method for Service Retirement.
a0ea408 
This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz

Added test for retirement_state equal 'retired'
Changed to use a service method
Fixed whitespace
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Nov 13, 2019
@billfitzgerald0120
Refactor start_retirement method for Service Retirement.
f65fb03 
This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz

Added test for service_retire_task = nil, was missing this in coverage
Added test for retirement_state = 'retiring' as requested

Modified method as requested
Deleted comment and blank line
Removed extra log messages because Raise doesn't need them
Fixed rob error
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Nov 14, 2019
@billfitzgerald0120
Refactor finish_retirement method for Service Retirement.
290de87 
This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz

Added test for retirement_state equal 'retired'
Changed to use a service method
Fixed whitespace
Added comment to not raise
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Nov 14, 2019
@billfitzgerald0120
Refactor start_retirement method for Infra VM Retirement.
3d63718 
This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz
Added test for retirement_start eq retiring as requested
Change method to add vm as a method
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Nov 14, 2019
@billfitzgerald0120
Refactor start_retirement method for Service Retirement.
b3f636a 
This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz

Added test for service_retire_task = nil, was missing this in coverage
Added test for retirement_state = 'retiring' as requested

Modified method as requested
Deleted comment and blank line
Removed extra log messages because Raise doesn't need them
Fixed rob error
Fixed raise logic to 1 line
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Dec 10, 2019
@billfitzgerald0120
Refactor start_retirement method for Cloud Orch Retirement.
5c926f2 
This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz
@billfitzgerald0120 billfitzgerald0120 mentioned this issue Dec 11, 2019
Merged
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Dec 12, 2019
@billfitzgerald0120
Refactor start_retirement method for Cloud Orch Retirement.
29140d7 
This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz

Since I refactored the method the old spec tests failed.
Removed old spec test from orchestration_retirement_spec.rb
    in spec/automation/unit/method_validation
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Jan 7, 2020
@billfitzgerald0120
Refactor microsoft_best_fit_least_utilized method for Infra VM Placem…
468c42b 
…ent.

Refactored method and test.
Removed old test.

This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz
@billfitzgerald0120 billfitzgerald0120 mentioned this issue Jan 7, 2020
Merged
@pkomanek pkomanek mentioned this issue Jan 9, 2020
Merged
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Jan 14, 2020
@billfitzgerald0120
Refactor microsoft_best_fit_least_utilized method for Infra VM Placem…
30285a1 
…ent.

Refactored method and test.
Removed old test.

This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz

Added check for ems
Removed storage profile as requested
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Jan 14, 2020
@billfitzgerald0120
Refactor redhat_best_fit_cluster method for VM Placement.
84fbb2a 
Refactored method and created test.

This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz
@billfitzgerald0120 billfitzgerald0120 mentioned this issue Jan 14, 2020
Merged
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Jan 16, 2020
@billfitzgerald0120
Refactor redhat_best_fit_cluster method for VM Placement.
96d939f 
Refactored method and created test.

This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz
Fixed description
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Jan 16, 2020
@billfitzgerald0120
Refactor redhat_best_fit_cluster method for VM Placement.
a9b9e8b 
Refactored method and created test.

This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz
Fixed description
Changed ems logic in method as requested
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Jan 16, 2020
@billfitzgerald0120
Refactor microsoft_best_fit_least_utilized method for Infra VM Placem…
6ace6e1 
…ent.

Refactored method and test.
Removed old test.

This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz

Added check for ems
Removed storage profile as requested
Changed ems logic in method as requested
This was referenced Jan 21, 2020
Merged
Merged
@pkomanek pkomanek mentioned this issue Feb 17, 2020
Merged
This was referenced Mar 5, 2020
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmcculloug gmcculloug

Labels
automate/model
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmcculloug @mkanoor