Refactoring available_os_types method for miq_ae_orchestrations.

[pkomanek]

Purpose or Intent

Refactoring the available_os_types method for the miq_ae_orchestration based on the issue bellow.

Links [Optional]

#12038

[pkomanek]

@miq-bot add_labels automate, enhancement

[pkomanek]

@miq-bot add_label refactoring

[mkanoor]

@Fryguy @pkomanek @gmcculloug
@Fryguy had a suggestion that the classes should be namespaced so that we don't have conflicts when testing. should we create the class name based on the path
e.g. for this one ManageIQ::Cloud::Orchestration::Operations::AvailableOsTypes or
ManageIQ::Cloud::Orchestration::Operations::Methods::AvailableOsTypes.

@Fryguy please suggest.
Is the preferred way to have

module ManageIQ
  module Cloud
       module Orchestration
           module Operations
                module Methods
                     class AvailableOsTypes
                     end
          ...
          end

or

module ManageIQ::Cloud::Orchestration::Operations::Methods
  class AvailableOsTypes
  end
end

[Fryguy]

Gah I never sent the response @mkanoor :(

---

Although there are subtle differences, I would prefer the latter for readability.
Also, you should be careful in the ManageIQ namespace, because that is used by the ManageIQ::Api::Client and will probably also be used by the various provider gems at some point. You might want to stuff it into a ManageIQ::Automate top level namespace or something like that e.g:

module ManageIQ::Automate
  module Cloud::Orchestration::Operations::Methods
    class AvailableOsTypes
ennnd

[mkanoor]

@pkomanek
Can we follow Jason's suggestion and create everything with namespaces. The call at the bottom of the file and the specs would have to change.

[pkomanek]

@miq-bot add_label wip

[pkomanek]

@mkanoor Could be like this? The namespaces are not in inline syntax, because in this case they are not created and I get back this error: NameError: uninitialized constant ManageIQ::Automate::Cloud. I am open to any suggestion.

[pkomanek]

@mkanoor I could create ManageIQ::Automate::Cloud::Orchestration::Operations module somewhere(I dont know where) and after that I might use that inline syntax(same for other methods):

module Cloud::Orchestration::Operations::Methods
  class AvailableOsTypes
  end
end

[pkomanek]

@miq-bot remove_label wip

[miq-bot]

Checked commits pkomanek/manageiq@099bc0c~...f49398d with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 0 offenses detected
Everything looks good. 🍰