Refactor used quota method and test. #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @gmcculloug |
|
@tinaafitz Please Review |
billfitzgerald0120
force-pushed
the
used_active_provisions
branch
from
67e73c3 to
aa1ebe3
Compare
|
@tinaafitz Made changes as requested, Please Review |
billfitzgerald0120
force-pushed
the
used_active_provisions
branch
from
aa1ebe3 to
9cd896a
Compare
This PR is based on on the issue below. ManageIQ/manageiq#12038
|
Checked commit billfitzgerald0120@9cd896a with ruby 2.3.1, rubocop 0.47.1, and haml-lint 0.20.0 spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/methods/used_spec.rb
|
mkanoor
approved these changes
Oct 5, 2017
|
@miq-bot add_label fine/yes |
|
@billfitzgerald0120 Never mind... found it in #196 (comment) |
simaishi
pushed a commit
that referenced
this pull request
Nov 20, 2017
Refactor used quota method and test. (cherry picked from commit 5cc73ae) https://bugzilla.redhat.com/show_bug.cgi?id=1489507
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on on the issue below.
ManageIQ/manageiq#12038
@miq-bot add_label refactoring