Refactoring available_resource_groups method for miq_ae_orchestrations #12212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_labels automate, enhancement |
|
@miq-bot add_label refactoring |
|
@pkomanek |
pkomanek
changed the title
|
@miq-bot add_label wip |
|
@miq-bot remove_label wip |
pkomanek
changed the title
mkanoor
reviewed
Nov 17, 2016
| let(:default_desc_blank) { "<none>" } | ||
| let(:default_desc) { "<select>" } | ||
| let(:ems) do | ||
| @rgroup1 = FactoryGirl.create(:resource_group) |
There was a problem hiding this comment.
@pkomanek can we make this a let
|
Checked commits pkomanek/manageiq@54d354c~...0de3f11 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
mkanoor
approved these changes
Nov 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Refactoring the available_resource_groups method for the miq_ae_orchestration based on the issue bellow.
Links [Optional]
#12038