Refactor vmware_preprovision_clone_to_template method for VM Provisioning. #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4418
💛 - Coveralls |
pkomanek
force-pushed
the
vmware_preprovision_clone_to_template_method_refactoring
branch
from
f8a7b68 to
c852766
Compare
pkomanek
changed the title
|
Please address rubocop issues. |
pkomanek
force-pushed
the
vmware_preprovision_clone_to_template_method_refactoring
branch
from
c852766 to
085856f
Compare
|
Checked commits pkomanek/manageiq-content@e387c8e~...085856f with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
lfu
approved these changes
Mar 26, 2020
|
@tinaafitz This ok? |
tinaafitz
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method refactoring and test creation.
This PR is based on the issue below.
ManageIQ/manageiq#12038
@miq-bot add_label refactoring
@miq-bot assign @tinaafitz