Refactor openstack_customizerequest method for VM Provisioning. #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4293
💛 - Coveralls |
pkomanek
force-pushed
the
openstack_customizerequest_refactoring
branch
from
8294528 to
727ea44
Compare
pkomanek
changed the title
lfu
reviewed
Feb 20, 2020
| @@ -1,100 +1,167 @@ | |||
| # | |||
| # Description: This method is used to Customize the Openstack Provisioning Request | |||
| # Description: This method is used to Customize the Amazon Provisioning Request | |||
|
It looks good other than the typo. |
pkomanek
force-pushed
the
openstack_customizerequest_refactoring
branch
from
727ea44 to
4a9f0f7
Compare
|
Some comments on commits pkomanek/manageiq-content@e2c56be~...4a9f0f7 spec/content/automate/ManageIQ/Cloud/VM/Provisioning/StateMachines/Methods.class/methods/openstack_customizerequest_spec.rb
|
|
Checked commits pkomanek/manageiq-content@e2c56be~...4a9f0f7 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint content/automate/ManageIQ/Cloud/VM/Provisioning/StateMachines/Methods.class/methods/openstack_customizerequest.rb
|
lfu
approved these changes
Mar 5, 2020
tinaafitz
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method refactoring and creating tests.
This PR is based on the issue below.
ManageIQ/manageiq#12038
@miq-bot add_label refactoring
@miq-bot assign @tinaafitz