vm_controller and genericSessionMixin update #647

LANeo64 · 2017-03-10T08:48:47Z

@miq-bot assign himdel
@miq-bot add_label refactoring,euwe/no
Added changes to vm_controller to be compatible with GenereicSessionMixin

LANeo64 · 2017-03-10T09:11:57Z

@miq-bot remove_label wip

Fixs spelling.

Use `controllerAs vm` syntax for the Provider Foreman Angular controller (cleaner approach)

the session var is never used, and nor is @cats, not in here, nor in application controller...

only ever saved to session, never assigned to

only ever saved to session and back, no other uses

himdel · 2017-03-13T14:25:54Z

app/controllers/mixins/generic_session_mixin.rb

+      @display        = session["#{prefix}_display".to_sym]
+      @filters        = session["#{prefix}_filters".to_sym]
+      @catinfo        = session["#{prefix}_catinfo".to_sym]
+      @cats           = session["#{prefix}_cats".to_sym]


Sorry, removing @cats in #664 .. so no point in adding to the common mixin.. (turns out @cats is dead :))

…oject-id-when-adding-gce Update 'Project' to 'Project ID' when adding GCE Provider

…h_flash Fix volume attach/detach flash messages

https://bugzilla.redhat.com/show_bug.cgi?id=1431257

For middleware UI, only allow operations on mutable servers.

Make SCVMM "name@realm" hint declarative

Remove dead non-angular forms for EMS*

Add filter selections for the ad-hoc metrics page

Added spec test to verify that `fetch_playook_details` sets data for tabs correctly.

…alue Fixed checks around retirement dialog values.

https://bugzilla.redhat.com/show_bug.cgi?id=1432485

Code fix to display Resource Pools value/icon for selected Cluster https://bugzilla.redhat.com/show_bug.cgi?id=1324610

…ost_compare Fix double rendered icon on Hosts comparison delete column button

Crop the powerstate svg in quadicons using border-radius

Fixes simulate message passing

Display Cluster Resource Pool

…nsible_credentials Extended textual summary for ansible credentials

[WIP]Session mixin

[WIP] VM_controller session in generic_session_mixin [WIP]completed vm_controller to be compatible with GenericSessionMixin [WIP]vm_controller and generic session mixin update [WIP]vm_controller added private keyword

miq-bot · 2017-03-24T08:53:12Z

Checked commits LANeo64/manageiq-ui-classic@29ad7cb~...424d42f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 👍

LANeo64 · 2017-03-24T09:26:03Z

Performed a rebase and made suggested changes by @himdel

himdel · 2017-03-24T19:31:19Z

@LANeo64 looks like the main problem is that you don't have a branch for this PR, you're creating it from your master branch.

So, I suggest you close this PR, get your master branch to be identical to upstream/master (for example, by doing git checkout upstream/master; git branch -D master; git checkout -b master), and then you can create a fresh branch for this PR, and cherry-pick the right commits (also, please note that anything called "Merge ..." is not one of them).

himdel · 2017-04-05T13:29:41Z

Replaced by #865

miq-bot assigned himdel Mar 10, 2017

miq-bot added euwe/no refactoring wip labels Mar 10, 2017

LANeo64 changed the title ~~[WIP] Merge~~ [WIP] vm_controller and genericSessionMixin update Mar 10, 2017

miq-bot changed the title ~~[WIP] vm_controller and genericSessionMixin update~~ vm_controller and genericSessionMixin update Mar 10, 2017

miq-bot removed the wip label Mar 10, 2017

dclarizio added compute/infrastructure mixins labels Mar 11, 2017

romanblanco and others added 19 commits March 11, 2017 20:19

Split 'perf_menu_click' method to smaller method 'timeline_selected'

2f8108f

Split 'perf_menu_click' method to smaller method 'chart_current_hourly'

6ac19c4

Split 'perf_menu_click' method to smaller method 'chart_current_daily'

85dffc0

Split 'perf_menu_click' method to smaller method 'chart_selected'

dca419f

Split 'perf_menu_click' method to smaller method 'chart_top_by_tag'

213b527

Split 'perf_menu_click' method to smaller method 'chart_top'

2a9b50c

Store the messages to instance variable 'menu_click_msg'

590fb3d

Fixs spelling.

a507b3e

Merge pull request ManageIQ#662 from d-m-u/spellingVisibility

b8535a7

Fixs spelling.

Merge pull request ManageIQ#425 from AparnaKarve/creds_component

b79749f

Use `controllerAs vm` syntax for the Provider Foreman Angular controller (cleaner approach)

MiqDecorator - delegate #fonticon and #listicon_image to self.class

d128c03

Define MiqDecorator#fonticon as a class method where possible

8e985f9

Define MiqDecorator#listicon_image as a class method where possible

6f39714

Review response: removed unnecessary return

5342aba

MiqTemplateController - remove dead @cats

745fc7b

the session var is never used, and nor is @cats, not in here, nor in application controller...

ReportController - remove dead @cats

818dcb7

only ever saved to session, never assigned to

ConfigurationController - remove dead @cats

39476c5

only ever saved to session, never assigned to

Vm*Controller - remove dead @cats

6acd293

only ever saved to session and back, no other uses

Remove unnecessary console.log from charts JS

77174dc

himdel reviewed Mar 13, 2017

View reviewed changes

yaacov and others added 24 commits March 23, 2017 13:08

Add filter selections for the ad-hoc metrics page

a0e0a7a

remove confusing remoark

d9bc515

Merge pull request ManageIQ#747 from bmclaughlin/change-project-to-pr…

4465b14

…oject-id-when-adding-gce Update 'Project' to 'Project ID' when adding GCE Provider

Merge pull request ManageIQ#745 from gberginc/fix_volume_attach_detac…

207420d

…h_flash Fix volume attach/detach flash messages

Fix double rendered icon on Hosts comparison delete column button

4c85e83

https://bugzilla.redhat.com/show_bug.cgi?id=1431257

Merge pull request ManageIQ#636 from mtho11/mw-os-disable-cmds2

064885c

For middleware UI, only allow operations on mutable servers.

Merge pull request ManageIQ#679 from cben/scvmm-note

f4bdfe5

Make SCVMM "name@realm" hint declarative

Merge pull request ManageIQ#725 from himdel/multi-auth-remove

58b4222

Remove dead non-angular forms for EMS*

Merge pull request ManageIQ#735 from yaacov/ad-hoc-filter-options

6653e31

Add filter selections for the ad-hoc metrics page

Addressed code climate error

9709fdf

Added spec test to verify that `fetch_playook_details` sets data for tabs correctly.

Merge pull request ManageIQ#768 from h-kataria/fix_saving_of_dialog_v…

2184f6d

…alue Fixed checks around retirement dialog values.

Crop the powerstate svg in quadicons using border-radius

29a031e

https://bugzilla.redhat.com/show_bug.cgi?id=1432485

Display Cluster Resource Pool

01cadcc

Code fix to display Resource Pools value/icon for selected Cluster https://bugzilla.redhat.com/show_bug.cgi?id=1324610

Merge pull request ManageIQ#773 from jzigmund/bz1431257-button_icon_h…

2e83a4d

…ost_compare Fix double rendered icon on Hosts comparison delete column button

Merge pull request ManageIQ#778 from skateman/stretch-powerstate

6def6a8

Crop the powerstate svg in quadicons using border-radius

Merge pull request ManageIQ#742 from d-m-u/simulateMessagePassing

beb15af

Fixes simulate message passing

Extended textual summary for ansible credentials

088f77a

Merge pull request ManageIQ#785 from GregP/cluster_resource_pools

4592519

Display Cluster Resource Pool

Merge pull request ManageIQ#787 from mzazrivec/extended_summary_for_a…

bb54029

…nsible_credentials Extended textual summary for ansible credentials

[WIP]vm_controller and generic session mixin update

64c733d

[WIP]vm_controller added private keyword

6b9c4a5

Merge pull request #2 from LANeo64/session-mixin

267bb90

[WIP]Session mixin

Added mixin for session into vm_controller

3756938

[WIP] VM_controller session in generic_session_mixin [WIP]completed vm_controller to be compatible with GenericSessionMixin [WIP]vm_controller and generic session mixin update [WIP]vm_controller added private keyword

Merge branch 'master' of https://github.com/LANeo64/manageiq-ui-classic

424d42f

miq-bot removed the unmergeable label Mar 24, 2017

himdel closed this Mar 27, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vm_controller and genericSessionMixin update #647

vm_controller and genericSessionMixin update #647

LANeo64 commented Mar 10, 2017

LANeo64 commented Mar 10, 2017

himdel Mar 13, 2017 •

edited

Loading

miq-bot commented Mar 24, 2017

LANeo64 commented Mar 24, 2017

himdel commented Mar 24, 2017 •

edited

Loading

himdel commented Apr 5, 2017

vm_controller and genericSessionMixin update #647

vm_controller and genericSessionMixin update #647

Conversation

LANeo64 commented Mar 10, 2017

LANeo64 commented Mar 10, 2017

himdel Mar 13, 2017 • edited Loading

Choose a reason for hiding this comment

miq-bot commented Mar 24, 2017

LANeo64 commented Mar 24, 2017

himdel commented Mar 24, 2017 • edited Loading

himdel commented Apr 5, 2017

himdel Mar 13, 2017 •

edited

Loading

himdel commented Mar 24, 2017 •

edited

Loading