vm_controller and session mixin #865
Conversation
app/controllers/vm_controller.rb
Outdated
| session[:polArr] = @polArr unless @polArr.nil? | ||
| session[:policy_options] = @policy_options unless @policy_options.nil? | ||
| end | ||
|
|
||
| def title |
There was a problem hiding this comment.
Can you move the title method above private please?
(The respond_to?(:title) bit in GenericSessionMixin won't see it otherwise.)
|
@LANeo64 thanks, this looks good, adding Except for the title thing, LGTM :). |
removed some cosmetic things as spaces and empty lines
|
Uh, @LANeo64 just noticed a bit of a problem .. you're not using the mixin ;). No |
|
Ping @LANeo64 will you be able to add that |
|
@himdel Oh, sorry i totally forgot about it. It seems that i have no clue where the word |
too much indent because of an earlier (removed) change
Actually call super when using the mixin..
|
@LANeo64 OK, added :). @ZitaNemeckova can you please double-check? |
|
Checked commits LANeo64/manageiq-ui-classic@26c087b~...3990cfd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@himdel I see you are trying to pass it through the automatic tests, may i ask what is causing the errors? I looked up the errors from Travis and saw that something was missing. Can't recall the name tho... |
|
Ah, sorry @LANeo64, looks like that controller has since changed and no longer actually uses the session in any way... I'm still investigating, but we may have to close your PR, sorry :(. (But, for the purpose of grading, I'm marking this as green 👍 ) |
@miq-bot assign himdel
@miq-bot add_label refactoring,euwe/no
Added changes to vm_controller to be compatible with GenereicSessionMixin