Fix volume attach/detach flash messages #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flash message that is displayed right after a volume is
attached/detached, doe not properly substitute variables because the
volume name variable was incorrect (`name` instead of `volume_name`).
This patch updates the flash messagae substitutions.
Before the change:
```
Attaching Cloud Volume "%{volume_name}" to %{vm_name} finished
Detaching Cloud Volume "%{volume_name}" from %{vm_name} finished
```
After this change:
```
Attaching Cloud Volume "vol-aws1" to miq-t2.micro finished
Detaching Cloud Volume "vol-aws1" from miq-t2.micro finished
```
|
@miq-bot add_label bug,storage |
|
Checked commit gberginc@1f9cf59 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@AparnaKarve can you have a look at this one? If not, please assign to someone who can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flash message that is displayed right after a volume is attached/detached, doe not properly substitute variables because the volume name variable was incorrect (
nameinstead ofvolume_name).This patch updates the flash messagae substitutions.
Before the change:
After this change: