Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double rendered icon on Hosts comparison delete column button #773

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Fix double rendered icon on Hosts comparison delete column button #773

merged 1 commit into from
Mar 23, 2017

Conversation

jzigmund
Copy link

@jzigmund jzigmund commented Mar 23, 2017 •
edited
Loading

@jzigmund
Copy link
Author

Before fix:
screenshot from 2017-03-23 13-40-01

After fix:
screenshot from 2017-03-23 13-37-30

@miq-bot
Copy link
Member

miq-bot commented Mar 23, 2017

Checked commits jzigmund/manageiq-ui-classic@4c85e83~...e80872b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 3 offenses detected

app/views/layouts/_compare.html.haml

  • ⚠️ - Line 13 - Tagging a string as html safe may be a security risk, prefer safe_join or other Rails tag helpers instead.
  • ⚠️ - Line 18 - Tagging a string as html safe may be a security risk, prefer safe_join or other Rails tag helpers instead.
  • ⚠️ - Line 21 - Tagging a string as html safe may be a security risk, prefer safe_join or other Rails tag helpers instead.

@jzigmund jzigmund force-pushed the bz1431257-button_icon_host_compare branch from e80872b to 4c85e83 Compare March 23, 2017 12:51
@jzigmund
Copy link
Author

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Mar 23, 2017
This was referenced Mar 23, 2017
Merged
Closed
@dclarizio dclarizio self-assigned this Mar 23, 2017
@dclarizio dclarizio merged commit 2e83a4d into ManageIQ:master Mar 23, 2017
@dclarizio dclarizio added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
bug compute/infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzigmund @miq-bot @dclarizio