Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify compare/drift actions #777

Closed
jzigmund opened this issue Mar 23, 2017 · 2 comments
Closed

Unify compare/drift actions #777

jzigmund opened this issue Mar 23, 2017 · 2 comments
Labels

Comments

@jzigmund
Copy link

As I've fixed #773 and #775 noticed that controllers (i.e. host vs vm_infra) are not using the same flow to handle the comparison requests.
For Hosts are used ApplicationController#compare_miq (as HTML) vs. for VMs is used VmInfraController#x_button as JS what can cause other bugs. Also would be useful to refactor generating html without calling html_safe as it's not safe [1]

Created Issue with @skateman 's cooperation

[1] - http://www.rubydoc.info/gems/rubocop/0.41.2/RuboCop/Cop/Rails/OutputSafety

@miq-bot
Copy link
Member

miq-bot commented Jan 3, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot miq-bot added the stale label Jan 3, 2018
@JPrause
Copy link
Member

JPrause commented Jan 28, 2019

@h-kataria is this still a valid issue? If yes, lease remove the stale label. If not can you close.
If there's no update by next week, I'll be closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants