Fixes simulate message passing #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d-m-u Cannot apply the following label because they are not recognized: automate |
mkanoor
reviewed
Mar 20, 2017
| } | ||
| @resolve[:state_attributes] = {} if params[:button] == 'throw' | ||
| automation_attrs["message"] = @resolve[:new][:object_message] |
There was a problem hiding this comment.
@d-m-u In this line automation_attrs has not been initialized as a hash. Can you move this line to after line 149 when the automation_attrs is a hash
|
Checked commit d-m-u@bcc885d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
mkanoor
approved these changes
Mar 23, 2017
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the message passed to automate from simulate doesn't correctly get passed.
https://bugzilla.redhat.com/show_bug.cgi?id=1393501