Fixed checks around retirement dialog values. #768
Conversation
h-kataria
force-pushed
the
fix_saving_of_dialog_value
branch
from
427390c to
72f9494
Compare
|
@h-kataria - The 👍 LGTM |
h-kataria
force-pushed
the
fix_saving_of_dialog_value
branch
2 times, most recently
from
476823c to
6b0d2ae
Compare
- Retirement dialog is not a required field, so it is not always defined, checking if it is defined and has a value before setting it in retirement hash to be sent up via API call. - Fixed spec test failure
h-kataria
force-pushed
the
fix_saving_of_dialog_value
branch
from
6b0d2ae to
3ce463c
Compare
|
@h-kataria - These changes are working for me. I found an issue on my end where I'm not saving the new |
h-kataria
force-pushed
the
fix_saving_of_dialog_value
branch
from
f8124f6 to
60938b1
Compare
Added spec test to verify that `fetch_playook_details` sets data for tabs correctly.
h-kataria
force-pushed
the
fix_saving_of_dialog_value
branch
from
60938b1 to
9709fdf
Compare
|
Checked commits h-kataria/manageiq-ui-classic@b991bee~...9709fdf with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
| catalog_item['config_info']['retirement']['dialog_id'] = configData.retirement_dialog_id; | ||
| } else if (configData.retirement_dialog_name !== '') | ||
| } else if (angular.isDefined(vm.catalogItemModel.retirement_dialog_name) && configData.retirement_dialog_name !== '') |
There was a problem hiding this comment.
@h-kataria - Seeing a code climate error about not having a { after this if condition.
There was a problem hiding this comment.
@syncrou we usually add curly braces around if/else blocks if it has more than 1 statement in the block, so that comment can be ignored
There was a problem hiding this comment.
@h-kataria - I see now - the removed else if was that way. Looks good to me then.
👍
Retirement dialog is not a required field, so it is not always defined, checking if it is defined and has a value before setting it in retirement hash to be sent up via API call.
@syncrou please test this should fix the issue you found when trying to save new dialog name on Retirement tab.
@gmcculloug please review