Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move components from *ui-components #6716

Open
15 of 29 tasks
himdel opened this issue Feb 26, 2020 · 9 comments
Open
15 of 29 tasks

Move components from *ui-components #6716

himdel opened this issue Feb 26, 2020 · 9 comments
Labels
help wanted pinned refactoring

Comments

@himdel
Copy link
Contributor

himdel commented Feb 26, 2020 •
edited by kavyanekkalapu
Loading

Current state:

ManageIQ/ui-components:

  • uses release branches (gaprindashvili, hammer, ivanchuk, master), corresponding to 0.9 (bower), 1.0, 1.1 and 1.2 npm releases
  • no automatic releases (I tried)
  • typical bugfix means 3-7 PRs now (bugfix, update ui-classic master, update ui-service master, and then 2 PRs per backport), and I can only review the first one, because I'm creating the others (https://github.com/himdel/dotfiles/tree/master/ManageIQ)
  • especially in the cases of dialog-user and dialog-editor, there is more logic in ui-classic and ui-service to complement the ui-components part, could be simplified by merging
  • originally meant to serve to share angular components between ui-classic and ui-service, but only miq-select and dialog-user are actually used in ui-service
  • uses a demo/ folder for examples

ManageIQ/react-ui-components:

  • no release branches (the first need to backport something without all the rest came in Make repeatedly searching through Tag Categories and Values work react-ui-components#167), thus no way to backport things
  • automatic releases
  • but a ui-classic PR still needs to happen to update the version (the only reason the PR count isn't the same is that we can't backport)
  • ui-classic is the only user of the repo
  • uses storybook for examples (and a demo/ folder)

New state:

Any ui-components component used exclusively by SUI will be moved to SUI:

Any ui-components component used exclusively by ui-classic will be moved to ui-classic:

Any react-ui-components used exclusively by ui-classic will be moved to ui-classic:

Unfinished react-ui-components work that should be finished at some point:

The rest of ui-components:

  • dialog-user - used by ui-classic and SUI, with almost-copies of the API talking code in the respective repos - merge with that, release as a separate package (or replace by new ddf-based dialog player, if relevant by then)
  • miq-select - release as part of the @pf/select (our existing fork of bootstrap-select, the jquery part of miq-select) (or possibly as part of bootstrap-select itself, which I'm now also a maintainer of)

Documentation:

We should merge the demo & storybook into one place documenting all our components, and add entires for the existing ui-classic ones.

(Currently not sure whether to go with storybook, we don't use the knobs that much, and it comes at the cost of a third separate webpack configuration (in addition to jest).)
@himdel himdel added the pinned label Feb 26, 2020
@himdel
Copy link
Contributor Author

himdel commented Feb 26, 2020

Cc @chessbyte , re gitter ☝️ February 26, 2020 2:06 PM :)

@himdel himdel mentioned this issue Feb 26, 2020
Merged
@himdel
Copy link
Contributor Author

himdel commented Feb 26, 2020

(This is also relevant if we want ivanchuk to support node 12 - #6008 needs ManageIQ/react-ui-components#141.)

@himdel
Copy link
Contributor Author

himdel commented Feb 27, 2020 •
edited
Loading

Packages which depend on @manageiq/react-ui-components and are not ui-classic:

All the providers currently depend on an ancient version (0.9.5 vs 0.11.57),
and all are ui-classic UI plugins.

  • that will mean converting react final form forms to DDF

The UI already has the ManageIQ.component.addReact mechanism for exposing components to plugins, with the = react 'ComponentName', {props} rails helper, so it will consume those components using this mechanism, instead of directly importing older versions.

@himdel
Copy link
Contributor Author

himdel commented Mar 5, 2020

Cc @romanblanco

@himdel
Copy link
Contributor Author

himdel commented Mar 9, 2020

TODO(after): check whether patternfly-react 2.39.15 works now (in production) - see #6745

@ZitaNemeckova
Copy link
Contributor

ZitaNemeckova commented Mar 26, 2020 •
edited
Loading

Taking fonticon-picker :)

Edit: leaving i to @skateman :)

This was referenced Apr 6, 2020
Closed
Closed
Closed
Closed
@skateman
Copy link
Member

skateman commented Apr 20, 2020 •
edited
Loading

Gonna replace the angular version of the iconpicker with the react one in UIC if that's okay. It's assigned to me anyway.

@skateman skateman mentioned this issue Apr 20, 2020
Merged
@skateman
Copy link
Member

Taking vm-snapshot-form because it uses finalForm explicitly and it blocks me from upgrading to DDF2.

This was referenced Apr 28, 2020
Merged
Merged
Merged
Merged
Merged
Merged
@himdel himdel mentioned this issue Jun 18, 2020
Closed
@himdel himdel mentioned this issue Sep 2, 2020
Closed
@himdel himdel mentioned this issue Nov 30, 2020
Closed
@himdel himdel mentioned this issue Jan 27, 2021
Open
10 tasks
This was referenced Feb 8, 2021
Closed
Closed
@himdel himdel mentioned this issue Feb 8, 2021
Closed
@kavyanekkalapu kavyanekkalapu mentioned this issue Apr 6, 2021
Merged
@Fryguy
Copy link
Member

Fryguy commented Nov 1, 2021

cc @kavyanekkalapu

@Fryguy Fryguy added this to Roadmap Jun 12, 2024
@Fryguy Fryguy moved this to To do in Roadmap Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted pinned refactoring
Projects
Roadmap
Status: To do
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Fryguy @chessbyte @himdel @skateman @mfeifer @ZitaNemeckova