Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move dialog-editor to ui-classic #436

Closed
wants to merge 3 commits into from
Closed

[WIP] Move dialog-editor to ui-classic #436

wants to merge 3 commits into from

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Apr 6, 2020

Part of ManageIQ/manageiq-ui-classic#6716

ui-classic PR: ManageIQ/manageiq-ui-classic#6954
Can be merged in any order (once ready).

@miq-bot
Copy link
Member

miq-bot commented Apr 7, 2020

Checked commits https://github.com/himdel/ui-components/compare/adc4c7a5ddc03dbc73afb6347654c9a87884ab2d~...07f516407d6f567f767069096013fae8de4a2c81 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@h-kataria h-kataria requested a review from skateman April 17, 2020 13:48
@h-kataria h-kataria self-assigned this Apr 17, 2020
@himdel
Copy link
Contributor Author

himdel commented Apr 21, 2020

@miq-bot add_label wip

@miq-bot miq-bot changed the title Move dialog-editor to ui-classic [WIP] Move dialog-editor to ui-classic Apr 21, 2020
@miq-bot miq-bot added the wip label Apr 21, 2020
@miq-bot
Copy link
Member

miq-bot commented Apr 22, 2020

This pull request is not mergeable. Please rebase and repush.

@chessbyte
Copy link
Member

@himdel is this something you want to try to bring over the finish line?

@himdel
Copy link
Contributor Author

himdel commented Oct 14, 2020

Yes it is, still planing to finish this :).

@himdel
Copy link
Contributor Author

himdel commented Feb 8, 2021

Replaced by #455

@himdel himdel closed this Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants