Toolbar: React rewrite and simplification.

[martinpovolny]

• Use a new implementation of Toolbars in React.
• Simplify the logic around such as:
  • onClick handling (complex binding of buttons now replaced with simple React props),
  • remove dashboard_dropdown special handling,
  • remove miqInitToolbars,
  • toolbar now also unsubscribes from RxJS,
  • change the custom content mechanism for toolbars from HAML to React,
  • reimplement DashboardToolbar in React,
  • reimplement TopologyToolbar in React,

Requires: ManageIQ/react-ui-components#115

Rewrite BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1734662

[martinpovolny]

Thank you for the testing @epwinchell, will take a look and fix it.

[martinpovolny]

@epwinchell : fixed in ManageIQ/react-ui-components#154

I will wait for that to be merged and update the version dependency. Also I will update patterfly-react version to include a fix that removes a (wrong) warning.

[miq-bot]

Checked commits martinpovolny/manageiq-ui-classic@715bfbc~...1fe1acd with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
19 files checked, 10 offenses detected

app/helpers/application_helper/toolbar/catalogitem_button_center.rb

• ❗ - Line 35, Col 45 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/cloud/instance_operations_button_group_mixin.rb

• ❗ - Line 117, Col 70 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/custom_button_center.rb

• ❗ - Line 32, Col 45 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/ems_physical_infra_center.rb

• ❗ - Line 96, Col 49 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/report_view.rb

• ❗ - Line 51, Col 66 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 59, Col 66 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 67, Col 45 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/vm_performance.rb

• ❗ - Line 16, Col 61 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/x_vm_center.rb

• ❗ - Line 272, Col 68 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/x_vm_performance.rb

• ❗ - Line 16, Col 61 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

[himdel]

Not seeing any more issues, not in dashboard, or vms, or custom buttons, or GOD, so, 🤞 :)