Remove to_json from toolbar data as it's not needed #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After ManageIQ/manageiq-ui-classic#5997 `to_json` is not needed and will break the data format. Related to ManageIQ/manageiq-ui-classic#6289 fix
6 tasks
|
Checked commit ZitaNemeckova@34354e1 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Oct 10, 2019
agrare
added a commit
that referenced
this pull request
Oct 10, 2019
Remove to_json from toolbar data as it's not needed
|
👍 thanks @ZitaNemeckova ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After ManageIQ/manageiq-ui-classic#5997
to_jsonis not needed and will break the data format.Related to ManageIQ/manageiq-ui-classic#6289 fix but not dependent either way.
Before:
Buttons
Firmware UpdateandProvisiondon't work on click.After:
Buttons work as expected.
@miq-bot add_label ivanchuk/no