Toolbars - clean up, move remnants to gtl #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label wip test in the ui.. |
miq-bot
changed the title
29 tasks
We're using react toolbars since ManageIQ/manageiq-ui-classic#5997 the only remaining use of the toolbar code is from the GTL component, leaving only miq-toolbar-list and miq-toolbar-click.
GTL is using toolbar code so it always implicitly depended on toolbars, which explicitly depend on common, for the adjustColor filter now that there's no non-gtl toolbar code, moving the common dep to gtl (which also happens to fix the specs)
|
Checked commits https://github.com/himdel/ui-components/compare/2bcdce891b4648529cfa1002b6d5d7c4d4045cb9~...8596ed00858fcbaff5862b8b35a1d7f2a3d49534 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint |
|
@miq-bot remove_label wip The paging toolbar still looks the same, no errors. |
miq-bot
changed the title
This was referenced May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI-classic is using react toolbars since ManageIQ/manageiq-ui-classic#5997.
That means we can remove angular toolbars now.
Except the GTL component is using
miq-toolbar-list(and thus alsomiq-toolbar-click) for pagination.So, moving these 2 components over to the gtl/ section, and removing the rest.