Change toolbar delete buttons for Button and Button Group to use generic code

[ZitaNemeckova]

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1753388

Go to Automation -> Automate -> Generic Objects - > delete a custom button(with or without Custom Button Group it shouldn't matter)

Actual result:
There's an error popup and message for a sec. See Before pic.

Expected result:
No error message/popup. See After pic.

According to the BZ it happens in 70%.

This fix should work for all possible delete actions on Generic Object Definition page.

Before:

After:

@miq-bot add_label bug, generic objects, ivanchuk/yes, changelog/no, wip

Depends on #6289

[ZitaNemeckova]

@miq-bot remove_label wip

@romanblanco please have a look, thanks :)

[himdel]

app/assets/javascripts/components/generic_object/generic-object-definition-toolbar.js
21:      if (event.entity && (toolbar.recordId || ManageIQ.gridChecks.length > 0)) {
24:        if (toolbar.recordId) {
25:          toolbar.genericObjectDefinitions = _.union(toolbar.genericObjectDefinitions, [toolbar.recordId]);
40:    var currentRecordId = toolbar.recordId || ManageIQ.record.recordId;

It's unlikely that only one toolbar.recordId is wrong ;).

They should probably all go away, including the recordId entry in bindings?

[miq-bot]

@ZitaNemeckova unrecognized command 'add_albel', ignoring...

Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, remove_reviewer, set_milestone

[ZitaNemeckova]

@miq-bot add_label wip

[ZitaNemeckova]

@miq-bot remove_label wip

@romanblanco please have a look, thanks :)

[ZitaNemeckova]

@himdel It's ready for re-review :) Thanks :)

[himdel]

Thanks, I like the toolbar much more now :)

One more bit needed:

app/assets/javascripts/components/generic_object/generic-object-definition-toolbar.js
49:    } else if (toolbar.action === 'delete_custom_button_set' && currentRecordId) {
51:    } else if (toolbar.action === 'delete_custom_button' && currentRecordId) {

those are dead code now ;)

[ZitaNemeckova]

Removed :)

[miq-bot]

Checked commits ZitaNemeckova/manageiq-ui-classic@8f94aa7~...3073ae1 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 0 offenses detected
Everything looks fine. 🍪

[simaishi]

@ZitaNemeckova Trying to backport this to ivanchuk branch and have 2 questions..

• It says this PR depends on Fix toolbar button with function #6289, which is ivanchuk/no. I see Fix toolbar button with function #6289 fixed an issue introduced in Toolbar: React rewrite and simplification. #5997 which is also ivanchuk/no. So I assume backport doesn't need either of the PRs. Can this PR still go to ivanchuk as is?

• There was a conflict in one of the files and that led me to Fix missing name of deleted GOD Button/ButtonGroup #6214 (which is ivanchuk/yes). Since that PR is no longer needed and reverted in this PR, this PR will also fix 2 BZs mentioned in 6214 (https://bugzilla.redhat.com/show_bug.cgi?id=1744478 and https://bugzilla.redhat.com/show_bug.cgi?id=1753289) in ivanchuk even without Fix missing name of deleted GOD Button/ButtonGroup #6214 being backported. Is that correct?

[ZitaNemeckova]

@simaishi Thanks for catching this one.

• This PR needs Ivanchuk version non-dependable of those ivanchuk/no PRs.

• It should take care of Fix missing name of deleted GOD Button/ButtonGroup #6214 BZs as well. So 6214 isn't needed.

Should I tag this one as ivanchuk/conflict and 6214 as ivanchuk/no?

[simaishi]

@ZitaNemeckova yes, that will work. Thanks!

[ZitaNemeckova]

@miq-bot remove_label ivanchuk/yes
@miq-bot add_label ivanchuk/conflict

[simaishi]

Backported to Ivanchuk via #6380