[IVANCHUK] Toolbar delete button for Button/Button Group goes via generic API de… #6380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
changed the title
miq-bot
changed the title
…lete code not via genericObjectDefinitionToolbarController Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1753388
ZitaNemeckova
force-pushed
the
ivanchuk_delete_button_fix
branch
from
b3ea111 to
4a9d484
Compare
|
Checked commit ZitaNemeckova@4a9d484 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot remove_label wip @h-kataria please have a look, thanks :) |
ZitaNemeckova
changed the title
|
@miq-bot add_label bug |
martinpovolny
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ivanchuk version of #6230 and #6214 (that got reverted by #6230)
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1744478
https://bugzilla.redhat.com/show_bug.cgi?id=1753289
Go to Automation -> Automate -> Generic Objects -> delete a custom button (delete a custom button group to make sure it works as well)
Before:
or
After:
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1753388
Go to Automation -> Automate -> Generic Objects - > delete a custom button(with or without Custom Button Group it shouldn't matter)
Actual result:
There's an error popup and message for a sec. See Before pic.
Expected result:
No error message/popup. See After pic.
According to the BZ it happens in 70%.
This fix should work for all possible delete actions on Generic Object Definition page.
Before:
After:
@miq-bot add_label wip