This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
[WIP] Expression Editor #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanSpagetka
force-pushed
the
expression-editor2
branch
from
6886f57 to
d7d5a9e
Compare
PanSpagetka
force-pushed
the
expression-editor2
branch
2 times, most recently
from
b58921b to
b991832
Compare
PanSpagetka
force-pushed
the
expression-editor2
branch
2 times, most recently
from
da58583 to
85a75a0
Compare
PanSpagetka
force-pushed
the
expression-editor2
branch
2 times, most recently
from
8ae6954 to
93b65d3
Compare
PanSpagetka
force-pushed
the
expression-editor2
branch
from
93b65d3 to
42482a3
Compare
PanSpagetka
force-pushed
the
expression-editor2
branch
from
42482a3 to
973a1a8
Compare
|
Some comments on commits PanSpagetka/react-ui-components@8ae6954~...973a1a8 grammar.jison.js
|
|
Checked commits PanSpagetka/react-ui-components@8ae6954~...973a1a8 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
This pull request is not mergeable. Please rebase and repush. |
29 tasks
Closed
|
This pull request has been automatically closed because it has not been updated for at least 3 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is prototype of new Expression Editor. It has two basic functionalities: parsing(validation) and autocomplete(suggestions). For each of those there is a grammar.
Both grammar is using nearley and must be pregenerated using command
nearleyc grammar.ne -o grammar.ne.js. However the parser itself is statefull and doesn't support any kind of reset. So, for each input must be freshly instantiated , according to the authors kach/nearley#129 it is not performance issue.