Convert the Cloud Subnet Form to DDF and get rid of react-ui-components #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skateman Cannot add the following reviewer because they are not recognized: himdel |
|
@skateman Cannot apply the following label because they are not recognized:
All labels for |
skateman
force-pushed
the
drop-react-ui-components
branch
from
9666677 to
6d5bccc
Compare
|
I guess travis will fail until ManageIQ/manageiq-ui-classic#7005 is not merged |
skateman
commented
May 4, 2020
skateman
force-pushed
the
drop-react-ui-components
branch
from
6d5bccc to
3d444a5
Compare
|
Checked commits skateman/manageiq-providers-nuage@e8d7de5~...5ae336f with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
agrare
approved these changes
May 20, 2020
This was referenced May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This form is accessible from a Nuage Network Router's summary screen:
The look & feel should be the same, a lot of things got simplified, I used the FirmwareRegistryForm from the ui-classic as an inspiration. There's a piece of error handling that I changed. If the API returns an error while fetching the network router's data, I am displaying it as a flash message instead of printing it on the modal. The reason for this is because there's already a modal when an API error occurs.
Before:
After:
Except of this minor change, everything should behave the same.
This change allowed me to get rid of the
react-ui-componentsdependency in this repo, which resolves one more checkbox in ManageIQ/manageiq-ui-classic#6716 (comment)@miq-bot add_reviewer @himdel
@miq-bot add_label react, cleanup