This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Move tagging to ui-classic #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to backport tagging separately from the rest, we can either add react-ui-components release branches, or move the component to ui-classic. Doing the latter since that's the only place it's used.
This was referenced Feb 19, 2020
|
@miq-bot remove_label wip |
|
Checked commits https://github.com/himdel/react-ui-components/compare/ff55e08e8112f219836923dc8401b2eadf828efe~...7ac13f4a8cbc7afe13873ce794edd96841f4bf0e with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint |
Hyperkid123
approved these changes
Feb 26, 2020
29 tasks
|
🎉 This PR is included in version 0.11.64 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ManageIQ/manageiq-ui-classic#6691
We need to backport tagging separately from the rest,
we can either add react-ui-components release branches,
or move the component to ui-classic.
Doing the latter since that's the only place it's used.
One complication:
PfSelectand the associatedselect-styles.jsis used both by tagging and non-tagging code (report editor, forms), so..Cc @hstastna
@miq-bot add_label wip