rust 1.49.0 #68089

shigemk2 · 2020-12-31T18:00:10Z

Have you followed the guidelines for contributing?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

shigemk2 · 2020-12-31T18:30:48Z

I was able to install rust 1.49.0 in 10.15.7 and 11.1.
So I deleted Hardware::CPU.arm? conditions.

carlocab · 2021-01-01T03:26:43Z

Lots of errors on ARM:

Error: 123 failed steps!

Error: 123 failed steps!
brew install --build-from-source amp
brew install --build-from-source angle-grinder
brew install --build-from-source asuka
brew install --build-from-source badtouch
brew install --build-from-source bandwhich
brew install --build-from-source bingrep
brew install --build-from-source boringtun
brew install --build-from-source --only-dependencies caffe
brew install --build-from-source caffe
brew test --retry --verbose chromaprint
brew install --build-from-source click
brew install --build-from-source --only-dependencies dartsim
brew install --build-from-source dartsim
brew install --build-from-source deno
brew test --retry --verbose dnsviz
brew install --build-from-source --only-dependencies dog
brew install --build-from-source dog
brew install --build-from-source dssim
brew install --build-from-source echoprint-codegen
brew install --build-from-source --only-dependencies efl
brew install --build-from-source efl
brew install --build-from-source --only-dependencies evince
brew install --build-from-source evince
brew install --build-from-source exa
brew install --build-from-source fblog
brew test --retry --verbose ffmpegthumbnailer
brew install --build-from-source ffsend
brew install --build-from-source flux
brew install --build-from-source fnm
brew install --build-from-source --only-dependencies gedit
brew install --build-from-source gedit
brew install --build-from-source git-delta
brew install --build-from-source git-interactive-rebase-tool
brew install --build-from-source git-trim
brew install --build-from-source gjs
brew install --build-from-source --only-dependencies glade
brew install --build-from-source glade
brew install --build-from-source gleam
brew install --build-from-source --only-dependencies gnome-latex
brew install --build-from-source gnome-latex
brew install --build-from-source --only-dependencies gnome-recipes
brew install --build-from-source gnome-recipes
brew install --build-from-source --only-dependencies gnuradio
brew install --build-from-source gnuradio
brew install --build-from-source --only-dependencies gr-osmosdr
brew install --build-from-source gr-osmosdr
brew install --build-from-source --only-dependencies graph-tool
brew install --build-from-source graph-tool
brew install --build-from-source grin
brew install --build-from-source grin-wallet
brew install --build-from-source --only-dependencies gspell
brew install --build-from-source gspell
brew install --build-from-source --only-dependencies gtranslator
brew install --build-from-source gtranslator
brew test --retry --verbose ktmpl
brew install --only-dependencies --include-test kubie
brew test --retry --verbose kubie
brew install --build-from-source --only-dependencies lablgtk
brew install --build-from-source lablgtk
brew test --retry --verbose libgit2-glib
brew test --retry --verbose mat2
brew install --build-from-source meilisearch
brew install --build-from-source --only-dependencies mlpack
brew install --build-from-source mlpack
brew install --build-from-source --only-dependencies mlt
brew install --build-from-source mlt
brew install --build-from-source --only-dependencies moc
brew install --build-from-source moc
brew install --build-from-source mpv
brew test --retry --verbose ocrmypdf
brew install --build-from-source --only-dependencies openalpr
brew install --build-from-source openalpr
brew install --build-from-source opencv
brew install --build-from-source opencv@3
brew install --build-from-source --only-dependencies openimageio
brew install --build-from-source openimageio
brew install --build-from-source pcb2gcode
brew install --build-from-source pdfpc
brew install --build-from-source --only-dependencies pdfsandwich
brew install --build-from-source pdfsandwich
brew install --build-from-source --only-dependencies plantuml
brew install --build-from-source plantuml
brew install --build-from-source ppsspp
brew install --build-from-source --only-dependencies pushpin
brew install --build-from-source pushpin
brew install --build-from-source qcachegrind
brew install --build-from-source --only-dependencies qcli
brew install --build-from-source qcli
brew install --build-from-source --only-dependencies qmmp
brew install --build-from-source qmmp
brew install --build-from-source rbspy
brew install --build-from-source ripgrep-all
brew install --build-from-source rm-improved
brew install --build-from-source root
brew install --build-from-source rustscan
brew test --retry --verbose saltwater
brew install --build-from-source shadowenv
brew install --build-from-source silicon
brew install --build-from-source --only-dependencies simple-scan
brew install --build-from-source simple-scan
brew install --build-from-source --only-dependencies siril
brew install --build-from-source siril
brew install --build-from-source sonic
brew install --build-from-source spotifyd
brew install --build-from-source ssh-permit-a38
brew install --build-from-source starship
brew install --build-from-source --only-dependencies synfig
brew install --build-from-source synfig
brew install --build-from-source texlab
brew install --build-from-source tree-sitter
brew install --build-from-source uutils-coreutils
brew install --build-from-source vice
brew install --build-from-source --only-dependencies visp
brew install --build-from-source visp
brew install --build-from-source volta
brew install --build-from-source wagyu
brew install --build-from-source wapm
brew install --build-from-source wasm-pack
brew install --build-from-source wasmer
brew test --retry --verbose xdot
brew install --build-from-source zenith
brew install --build-from-source zim
brew install --build-from-source zola

shigemk2 · 2021-01-01T05:23:19Z

I want to wait all builds finishing and confirm the failures occurs only in 11-arm.

fxcoudert · 2021-01-01T10:14:45Z

cargobootstrap needs to be aarch64-apple-darwin on ARM (native building); use if Hardware::CPU.arm? for that
if Hardware::CPU.arm? block with inreplaces should be removed
remove caveats

shigemk2 · 2021-01-02T17:42:33Z

cargobootstrap needs to be aarch64-apple-darwin on ARM (native building); use if Hardware::CPU.arm? for that → I used if Hardware::CPU.arm?
if Hardware::CPU.arm? block with inreplaces should be removed → Install error occurs if removed.
remove caveats → I removed.

shigemk2 · 2021-01-02T17:57:05Z

This is an error when installing exa by brew install exa.

error: failed to run custom build command for libgit2-sys v0.8.1

But libgit2-sys's version when installing exa by cargo install exa is v0.8.2.

Similarly, this is an error when installing angle-grinder by brew install angle-grinder.

error: failed to run custom build command for ring v0.16.15

But ring's version when installing angle-grinder by cargo install angle-grinder is v0.16.19.

I have no idea about the solution for these errors yet.

shigemk2 · 2021-01-02T18:15:39Z

Homebrew's cargo install is using locked option, so Homebrew uses Cargo.lock.
https://www.rubydoc.info/github/Homebrew/brew/Formula#std_cargo_args-instance_method

That's why Homebrew's cargo installs older dependent packages.

shigemk2 · 2021-01-02T19:42:51Z

I created a new pull request that Homebrew will not use locked option when executing cargo install *std_cargo_args.
Homebrew/brew#10205

I tried to install some formulae depending rust, but I succeeded in installing them.

amp
angle-grinder
exa

chenrui333 · 2021-01-02T20:14:04Z

Could we submit the cargo.lock patch to workaround with the outdated dependencies? Using lockfile is generally considered best practice.

carlocab · 2021-01-03T11:58:07Z

Latest ARM Failures:

This list is almost identical to the previous one, except for:

dprint (failed now, did not fail previously)
mpv (failed previously, did not fail now)

Error: 123 failed steps!

Error: 123 failed steps!
brew install --build-from-source amp
brew install --build-from-source angle-grinder
brew install --build-from-source asuka
brew install --build-from-source badtouch
brew install --build-from-source bandwhich
brew install --build-from-source bingrep
brew install --build-from-source boringtun
brew install --build-from-source --only-dependencies caffe
brew install --build-from-source caffe
brew test --retry --verbose chromaprint
brew install --build-from-source click
brew install --build-from-source --only-dependencies dartsim
brew install --build-from-source dartsim
brew install --build-from-source deno
brew test --retry --verbose dnsviz
brew install --build-from-source --only-dependencies dog
brew install --build-from-source dog
brew install --build-from-source dprint
brew install --build-from-source dssim
brew install --build-from-source echoprint-codegen
brew install --build-from-source --only-dependencies efl
brew install --build-from-source efl
brew install --build-from-source --only-dependencies evince
brew install --build-from-source evince
brew install --build-from-source exa
brew install --build-from-source fblog
brew test --retry --verbose ffmpegthumbnailer
brew install --build-from-source ffsend
brew install --build-from-source flux
brew install --build-from-source fnm
brew install --build-from-source --only-dependencies gedit
brew install --build-from-source gedit
brew install --build-from-source git-delta
brew install --build-from-source git-interactive-rebase-tool
brew install --build-from-source git-trim
brew install --build-from-source gjs
brew install --build-from-source --only-dependencies glade
brew install --build-from-source glade
brew install --build-from-source gleam
brew install --build-from-source --only-dependencies gnome-latex
brew install --build-from-source gnome-latex
brew install --build-from-source --only-dependencies gnome-recipes
brew install --build-from-source gnome-recipes
brew install --build-from-source --only-dependencies gnuradio
brew install --build-from-source gnuradio
brew install --build-from-source --only-dependencies gr-osmosdr
brew install --build-from-source gr-osmosdr
brew install --build-from-source --only-dependencies graph-tool
brew install --build-from-source graph-tool
brew install --build-from-source grin
brew install --build-from-source grin-wallet
brew install --build-from-source --only-dependencies gspell
brew install --build-from-source gspell
brew install --build-from-source --only-dependencies gtranslator
brew install --build-from-source gtranslator
brew test --retry --verbose ktmpl
brew install --only-dependencies --include-test kubie
brew test --retry --verbose kubie
brew install --build-from-source --only-dependencies lablgtk
brew install --build-from-source lablgtk
brew test --retry --verbose libgit2-glib
brew test --retry --verbose mat2
brew install --build-from-source meilisearch
brew install --build-from-source --only-dependencies mlpack
brew install --build-from-source mlpack
brew install --build-from-source --only-dependencies mlt
brew install --build-from-source mlt
brew install --build-from-source --only-dependencies moc
brew install --build-from-source moc
brew test --retry --verbose ocrmypdf
brew install --build-from-source --only-dependencies openalpr
brew install --build-from-source openalpr
brew install --build-from-source opencv
brew install --build-from-source opencv@3
brew install --build-from-source --only-dependencies openimageio
brew install --build-from-source openimageio
brew install --build-from-source pcb2gcode
brew install --build-from-source pdfpc
brew install --build-from-source --only-dependencies pdfsandwich
brew install --build-from-source pdfsandwich
brew install --build-from-source --only-dependencies plantuml
brew install --build-from-source plantuml
brew install --build-from-source ppsspp
brew install --build-from-source --only-dependencies pushpin
brew install --build-from-source pushpin
brew install --build-from-source qcachegrind
brew install --build-from-source --only-dependencies qcli
brew install --build-from-source qcli
brew install --build-from-source --only-dependencies qmmp
brew install --build-from-source qmmp
brew install --build-from-source rbspy
brew install --build-from-source ripgrep-all
brew install --build-from-source rm-improved
brew install --build-from-source root
brew install --build-from-source rustscan
brew test --retry --verbose saltwater
brew install --build-from-source shadowenv
brew install --build-from-source silicon
brew install --build-from-source --only-dependencies simple-scan
brew install --build-from-source simple-scan
brew install --build-from-source --only-dependencies siril
brew install --build-from-source siril
brew install --build-from-source sonic
brew install --build-from-source spotifyd
brew install --build-from-source ssh-permit-a38
brew install --build-from-source starship
brew install --build-from-source --only-dependencies synfig
brew install --build-from-source synfig
brew install --build-from-source texlab
brew install --build-from-source tree-sitter
brew install --build-from-source uutils-coreutils
brew install --build-from-source vice
brew install --build-from-source --only-dependencies visp
brew install --build-from-source visp
brew install --build-from-source volta
brew install --build-from-source wagyu
brew install --build-from-source wapm
brew install --build-from-source wasm-pack
brew install --build-from-source wasmer
brew test --retry --verbose xdot
brew install --build-from-source zenith
brew install --build-from-source zim

carlocab · 2021-01-03T11:59:37Z

@shigemk2, can you try the suggestion I made here? Homebrew/brew#10205 (comment)

You can put all the rust-based formula changes in one commit, since we don't intend on merging them anyway. Marking this as do-not-merge in the meantime so that no one tries to merge the experimental changes.

shigemk2 · 2021-01-03T12:07:16Z

I will try it.

carlocab · 2021-01-03T12:11:36Z

Great, thanks. Let me know if you need any help.

shigemk2 · 2021-01-03T14:17:44Z

@carlocab
I fixed the script replacing std_cargo_args in amp.rb first. Please check it.
https://github.com/Homebrew/homebrew-core/pull/68089/files#diff-c85503925ce4481fe9c0fe47c5294ed3fd48a1f1981acd96f05577b76d4179c0R23-R27

carlocab · 2021-01-03T14:20:48Z

Formula/rust.rb

    if Hardware::CPU.arm?
      # Fix for 1.49.0-beta, remove when the stable version is released
-      inreplace "src/stage0.txt", "1.48.0", "beta"
-      inreplace "src/stage0.txt", "2020-11-19", "2020-12-23"
+      inreplace "src/stage0.txt", "1.48.0", "1.49.0"
+      inreplace "src/stage0.txt", "2020-11-19", "2020-12-31"
    end


Is this still needed? The comment says it should be removed.

I can't install rust if this block is removed.

curl: (22) The requested URL returned error: 404 failed to run: curl -s -y 30 -Y 10 --connect-timeout 30 --retry 3 -Sf -o /private/tmp/xxxxxx.sha256 https://static.rust-lang.org/dist/2020-11-19/rust-std-1.48.0-aarch64-apple-darwin.tar.xz.sha256 Build completed unsuccessfully in 0:00:01 make: *** [all] Error 1

This is what stage0.txt says:

# This file describes the stage0 compiler that's used to then bootstrap the Rust # compiler itself. # # Currently Rust always bootstraps from the previous stable release, and in our # train model this means that the master branch bootstraps from beta, beta # bootstraps from current stable, and stable bootstraps from the previous stable # release. # # If you're looking at this file on the master branch, you'll likely see that # rustc is configured to `beta`, whereas if you're looking at a source tarball # for a stable release you'll likely see `1.x.0` for rustc, with the previous # stable release's version number. `date` is the date where the release we're # bootstrapping off was released.

So it is needed until the previous stable version supports ARM. Perhaps just update the comment to say "remove when the 2nd stable ARM version is released"?

carlocab · 2021-01-03T14:21:16Z

Formula/amp.rb

+    if Hardware::CPU.arch == :arm64
+      system "cargo", "install", "--root", prefix, "--path", "."
+    else
+      system "cargo", "install", *std_cargo_args
+    end


This looks great! 👏

OK. Thank you.
I will fix any other formulae like this amp.rb after checking brew install --build-from-source amp is finished.

Btw, I think you can actually do

Suggested change

if Hardware::CPU.arch == :arm64

system "cargo", "install", "--root", prefix, "--path", "."

else

system "cargo", "install", *std_cargo_args

end

if Hardware::CPU.arm?

system "cargo", "install", "--root", prefix, "--path", "."

else

system "cargo", "install", *std_cargo_args

end

No need to change your script, though, since these won't be permanent changes.

carlocab · 2021-01-03T14:22:44Z

One comment: keep the modifications to the formulae that depend on Rust in a commit separate to the one where you modify rust.rb. That will allow you to quickly drop the experimental changes made later on.

aimileus · 2021-01-03T14:24:10Z

Most failed rust packages only need the cc package in the lock file updated, so that cargo update -p cc is sufficient to build the formula.

shigemk2 · 2021-01-03T14:46:30Z

Btw, it takes almost 30 minutes to install rust even in Apple Silicon, so I want to use MAKEFLAGS.

shigemk2 · 2021-01-04T01:46:18Z

ARM Error

Error: 121 failed steps!

brew install --build-from-source angle-grinder

brew install --build-from-source asuka
brew install --build-from-source badtouch
brew install --build-from-source bandwhich
brew install --build-from-source bingrep
brew install --build-from-source boringtun
brew install --build-from-source --only-dependencies caffe
brew install --build-from-source caffe
brew test --retry --verbose chromaprint
brew install --build-from-source click
brew install --build-from-source --only-dependencies dartsim
brew install --build-from-source dartsim
brew install --build-from-source deno
brew test --retry --verbose dnsviz
brew install --build-from-source --only-dependencies dog
brew install --build-from-source dog
brew install --build-from-source dprint
brew install --build-from-source dssim
brew install --build-from-source echoprint-codegen
brew install --build-from-source --only-dependencies efl
brew install --build-from-source efl
brew install --build-from-source --only-dependencies evince
brew install --build-from-source evince
brew install --build-from-source exa
brew install --build-from-source fblog
brew test --retry --verbose ffmpegthumbnailer
brew install --build-from-source ffsend
brew install --build-from-source flux
brew install --build-from-source fnm
brew install --build-from-source --only-dependencies gedit
brew install --build-from-source gedit
brew install --build-from-source git-delta
brew install --build-from-source git-interactive-rebase-tool
brew install --build-from-source git-trim
brew install --build-from-source gjs
brew install --build-from-source --only-dependencies glade
brew install --build-from-source glade
brew install --build-from-source gleam
brew install --build-from-source --only-dependencies gnome-latex
brew install --build-from-source gnome-latex
brew install --build-from-source --only-dependencies gnome-recipes
brew install --build-from-source gnome-recipes
brew install --build-from-source --only-dependencies gnuradio
brew install --build-from-source gnuradio
brew install --build-from-source --only-dependencies gr-osmosdr
brew install --build-from-source gr-osmosdr
brew install --build-from-source --only-dependencies graph-tool
brew install --build-from-source graph-tool
brew install --build-from-source grin
brew install --build-from-source grin-wallet
brew install --build-from-source --only-dependencies gspell
brew install --build-from-source gspell
brew install --build-from-source --only-dependencies gtranslator
brew install --build-from-source gtranslator
brew test --retry --verbose ktmpl
brew install --only-dependencies --include-test kubie
brew test --retry --verbose kubie
brew install --build-from-source --only-dependencies lablgtk
brew install --build-from-source lablgtk
brew test --retry --verbose libgit2-glib
brew test --retry --verbose mat2
brew install --build-from-source meilisearch
brew install --build-from-source --only-dependencies mlpack
brew install --build-from-source mlpack
brew install --build-from-source --only-dependencies mlt
brew install --build-from-source mlt
brew install --build-from-source --only-dependencies moc
brew install --build-from-source moc
brew test --retry --verbose ocrmypdf
brew install --build-from-source --only-dependencies openalpr
brew install --build-from-source openalpr
brew install --build-from-source opencv
brew install --build-from-source opencv@3
brew install --build-from-source --only-dependencies openimageio
brew install --build-from-source openimageio
brew install --build-from-source pcb2gcode
brew install --build-from-source pdfpc
brew install --build-from-source --only-dependencies pdfsandwich
brew install --build-from-source pdfsandwich
brew install --build-from-source --only-dependencies plantuml
brew install --build-from-source plantuml
brew install --build-from-source ppsspp
brew install --build-from-source --only-dependencies pushpin
brew install --build-from-source pushpin
brew install --build-from-source qcachegrind
brew install --build-from-source --only-dependencies qcli
brew install --build-from-source qcli
brew install --build-from-source --only-dependencies qmmp
brew install --build-from-source qmmp
brew install --build-from-source rbspy
brew install --build-from-source ripgrep-all
brew install --build-from-source rm-improved
brew install --build-from-source root
brew install --build-from-source rustscan
brew test --retry --verbose saltwater
brew install --build-from-source shadowenv
brew install --build-from-source silicon
brew install --build-from-source --only-dependencies simple-scan
brew install --build-from-source simple-scan
brew install --build-from-source --only-dependencies siril
brew install --build-from-source siril
brew install --build-from-source sonic
brew install --build-from-source spotifyd
brew install --build-from-source ssh-permit-a38
brew install --build-from-source --only-dependencies synfig
brew install --build-from-source synfig
brew install --build-from-source texlab
brew install --build-from-source tree-sitter
brew install --build-from-source uutils-coreutils
brew install --build-from-source vice
brew install --build-from-source --only-dependencies visp
brew install --build-from-source visp
brew install --build-from-source volta
brew install --build-from-source wagyu
brew install --build-from-source wapm
brew install --build-from-source wasm-pack
brew install --build-from-source wasmer
brew test --retry --verbose xdot
brew install --build-from-source zenith
brew install --build-from-source zim
brew install --build-from-source zola

carlocab · 2021-01-07T21:48:01Z

On 10.14:

Error: 5 failed steps!
brew test --retry --verbose ktmpl
brew install --build-from-source pcb2gcode
brew install --build-from-source vice
brew install --build-from-source websocat
brew install --build-from-source zenith

carlocab · 2021-01-07T21:53:13Z

pcb2gcode build error:

checking for glibmm-2.4 >= 2.8... no
configure: error: Package requirements (glibmm-2.4 >= 2.8) were not met:

No package 'glibmm-2.4' found

Same error as in #68428.

vice build error:

configure: error: Cannot find the OpenGL Extension Wrangler Library, GLEW. (brew install glew)

websocat build error:

error: failed to compile `websocat v1.6.0 (/private/tmp/websocat-20210107-13271-g5cgsn/websocat-1.6.0)`, intermediate artifacts can be found at `/private/tmp/websocat-20210107-13271-g5cgsn/websocat-1.6.0/target`

Caused by:
  failed to download from `https://crates.io/api/v1/crates/smart-default/0.3.0/download`

Caused by:
  failed to get 200 response from `https://crates.io/api/v1/crates/smart-default/0.3.0/download`, got 502

zenith has plenty of build errors:

error: aborting due to 175 previous errors

For more information about this error, try `rustc --explain E0277`.
error: failed to compile `zenith v0.11.0 (/private/tmp/zenith-20210107-26054-1r7m6oc/zenith-0.11.0)`, intermediate artifacts can be found at `/private/tmp/zenith-20210107-26054-1r7m6oc/zenith-0.11.0/target`

carlocab · 2021-01-07T23:28:49Z

On Big Sur:

Error: 11 failed steps!
brew test --retry --verbose asuka
brew test --retry --verbose asuka
brew install --build-from-source dartsim
brew install --build-from-source deno
brew install --build-from-source echoprint-codegen
brew install --build-from-source gjs
brew test --retry --verbose ktmpl
brew install --build-from-source pcb2gcode
brew install --build-from-source vice
brew install --build-from-source visp
brew install --build-from-source zenith

asuka has been documented here: #66450

Not sure what to say about the rest that aren't present in Mojave. If someone could investigate and help resolve any of these errors, that would help this PR along.

carlocab · 2021-01-08T00:25:32Z

Catalina:

Error: 5 failed steps!
brew test --retry --verbose ktmpl
brew install --build-from-source pcb2gcode
brew install --build-from-source rustscan
brew install --build-from-source vice
brew install --build-from-source zenith

carlocab · 2021-01-08T00:35:57Z

Ok, to test whether the 12 failures on Mojave, Catalina and Big Sur are regressions due to Rust 1.49, I am running CI tests on the 12 failed formulae on GitHub runners using the existing Rust formula (1.48).

If the failures are exactly the same, then we know that the failures aren't because of the version bump.

CI run here: https://github.com/carlocab/homebrew-personal/pull/26/checks

richiksc · 2021-01-08T05:04:45Z

Errors from @carlocab's Rust 1.48 build of failing formulae:

brew audit carlocab/personal/[email protected] --online --new-formula
brew test --verbose carlocab/personal/[email protected]
brew install --verbose --build-bottle carlocab/personal/[email protected]

The macos-11.0 build never ran with an 'Internal error', which is a known issue I've been facing with macos-11.0 GitHub Actions runners and has been reported before.

Looks like the primary regressions are rustscan, vice, websocat, and zenith.

carlocab · 2021-01-08T12:02:28Z

I restarted it to see if the Big Sur runner would work:

Error: 7 failed steps!
brew install --verbose --build-bottle carlocab/personal/[email protected]
brew install --verbose --build-bottle carlocab/personal/[email protected]
brew audit carlocab/personal/[email protected] --online --new-formula
brew install --verbose --build-bottle carlocab/personal/[email protected]
brew test --verbose carlocab/personal/[email protected]
brew install --verbose --build-bottle carlocab/personal/[email protected]
brew install --verbose --build-bottle carlocab/personal/[email protected]

We can ignore the audit failure; that's not relevant here.

carlocab · 2021-01-08T12:12:13Z

rustscan:

error: failed to compile `rustscan v2.0.0 (/private/tmp/rustscan-20210107-16598-1xntg7j/RustScan-2.0.1)`, intermediate artifacts can be found at `/private/tmp/rustscan-20210107-16598-1xntg7j/RustScan-2.0.1/target`

Caused by:
  failed to download from `https://crates.io/api/v1/crates/text_placeholder/0.4.0/download`

Caused by:
  failed to get 200 response from `https://crates.io/api/v1/crates/text_placeholder/0.4.0/download`, got 502

rustscan and websocat look like transient network failures. We need to understand vice and zenith.

carlocab · 2021-01-08T12:13:42Z

Rebased against master.

fxcoudert · 2021-01-08T12:34:24Z

@carlocab was the rebase made necessary by my commit at 479296d?
If so, I'm sorry :(

carlocab · 2021-01-08T13:23:29Z

@fxcoudert always a risk with these big heavy PRs! At least it'll give me a chance to poke at some of these failures again...

carlocab · 2021-01-09T17:25:01Z

vice is a test-bot bug. The vice failure is because test-bot does brew unlink glew sometime before brew install vice, but never links it back again.

Ref.
https://github.com/Homebrew/homebrew-core/runs/1655914149#step:7:3702
#67615
Homebrew/homebrew-test-bot#544

carlocab · 2021-01-10T00:44:05Z

zenith failure looks like it could be fixed by bvaisvil/zenith#90

carlocab · 2021-01-10T01:53:04Z

Ok, rustscan and websocat failures are gone, so I don't think they're regressions.

The only real one appears to be zenith, for which I think I've found a fix above. Someone ping me tomorrow if I forget to open a PR for it. mpd and minidlna bottles appear to have gone missing, but those shouldn't block this.

Merging.

BrewTestBot · 2021-01-10T01:53:40Z

@carlocab has triggered a merge.

shigemk2 · 2021-01-10T14:51:42Z

thank you everyone for your comments!

Fixes CI failure in Homebrew#68089.

BrewTestBot added the python Python use is a significant feature of the PR or issue label Dec 31, 2020

This comment has been minimized.

Sign in to view

ariasuni mentioned this pull request Jan 1, 2021

Support for Apple Silicon ogham/exa#780

Closed

shigemk2 force-pushed the rust-1.49.0 branch from 3ce6f17 to 6326cce Compare January 2, 2021 17:40

shigemk2 mentioned this pull request Jan 2, 2021

Remove locked option in std_cargo_args if CPU.arch is arm64 Homebrew/brew#10205

Closed

8 tasks

carlocab added the do not merge label Jan 3, 2021

shigemk2 force-pushed the rust-1.49.0 branch from 6326cce to d99e867 Compare January 3, 2021 14:16

BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Jan 3, 2021

carlocab reviewed Jan 3, 2021

View reviewed changes

carlocab mentioned this pull request Jan 3, 2021

Apple Silicon support in Homebrew Homebrew/brew#10152

Closed

ehuss mentioned this pull request Jan 7, 2021

Crashes on Apple Silicon M1 when installed through homebrew rust-lang/cargo#9007

Closed

rust 1.49.0

397724a

carlocab force-pushed the rust-1.49.0 branch from 88480a0 to 397724a Compare January 8, 2021 12:13

BrewTestBot closed this in 0c39a1a Jan 10, 2021

carlocab mentioned this pull request Jan 10, 2021

zenith: patch stale lock file #68720

Closed

5 tasks

This was referenced Jan 10, 2021

Outdated Cargo.lock file? imsnif/bandwhich#207

Closed

Outdated Cargo.lock file? m4b/bingrep#29

Closed

Outdated Cargo.lock file? bvaisvil/zenith#92

Closed

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jan 10, 2021

zenith: patch stale lock file

88b6b4b

Fixes CI failure in Homebrew#68089.

carlocab mentioned this pull request Jan 14, 2021

Outdated Cargo.lock file? gleam-lang/gleam#920

Closed

BrewTestBot added the outdated PR was locked due to age label Feb 10, 2021

Homebrew locked as resolved and limited conversation to collaborators Feb 10, 2021

rust 1.49.0 #68089

rust 1.49.0 #68089

Conversation

shigemk2 commented Dec 31, 2020 • edited Loading

shigemk2 commented Dec 31, 2020

This comment has been minimized.

This comment has been minimized.

carlocab commented Jan 1, 2021

shigemk2 commented Jan 1, 2021

fxcoudert commented Jan 1, 2021

shigemk2 commented Jan 2, 2021

shigemk2 commented Jan 2, 2021

shigemk2 commented Jan 2, 2021

shigemk2 commented Jan 2, 2021 • edited Loading

chenrui333 commented Jan 2, 2021

carlocab commented Jan 3, 2021

carlocab commented Jan 3, 2021

shigemk2 commented Jan 3, 2021

carlocab commented Jan 3, 2021

shigemk2 commented Jan 3, 2021

carlocab Jan 3, 2021

Choose a reason for hiding this comment

shigemk2 Jan 3, 2021

Choose a reason for hiding this comment

kenips Jan 6, 2021

Choose a reason for hiding this comment

carlocab Jan 3, 2021

Choose a reason for hiding this comment

shigemk2 Jan 3, 2021

Choose a reason for hiding this comment

carlocab Jan 3, 2021

Choose a reason for hiding this comment

carlocab commented Jan 3, 2021

aimileus commented Jan 3, 2021 • edited Loading

shigemk2 commented Jan 3, 2021

shigemk2 commented Jan 4, 2021

carlocab commented Jan 7, 2021

carlocab commented Jan 7, 2021 • edited Loading

carlocab commented Jan 7, 2021

carlocab commented Jan 8, 2021

carlocab commented Jan 8, 2021 • edited Loading

richiksc commented Jan 8, 2021

carlocab commented Jan 8, 2021

carlocab commented Jan 8, 2021

carlocab commented Jan 8, 2021

fxcoudert commented Jan 8, 2021

carlocab commented Jan 8, 2021

carlocab commented Jan 9, 2021

carlocab commented Jan 10, 2021

carlocab commented Jan 10, 2021

BrewTestBot commented Jan 10, 2021

shigemk2 commented Jan 10, 2021

shigemk2 commented Dec 31, 2020 •

edited

Loading

shigemk2 commented Jan 2, 2021 •

edited

Loading

aimileus commented Jan 3, 2021 •

edited

Loading

carlocab commented Jan 7, 2021 •

edited

Loading

carlocab commented Jan 8, 2021 •

edited

Loading