Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated Cargo.lock file? #29

Closed
carlocab opened this issue Jan 10, 2021 · 4 comments
Closed

Outdated Cargo.lock file? #29

carlocab opened this issue Jan 10, 2021 · 4 comments

Comments

@carlocab
Copy link

bingrep is currently failing to build for Homebrew with Rust 1.49 on Apple Silicon: Homebrew/homebrew-core#68089

It appears this is due to a stale lock file, causing cargo install --locked to pull in dependencies that do not work for bingrep on Apple Silicon. Is it possible for the Cargo.lock file to be updated? If this could be done with a new release, that would be especially helpful.

Related: Homebrew/homebrew-core#68301

@m4b
Copy link
Owner

m4b commented Jan 11, 2021

What is the specific error exactly ? Anyway I updated lock file, let me know if there are any other issues !

@carlocab
Copy link
Author

I didn't get the chance to look at the specific error message, unfortunately, as I was also looking at about a hundred other packages that use Rust to build.

All I know is that bingrep fails to build with cargo install --locked, but does not fail when the --locked flag was dropped. It's a very crude test, but it's proved to be correct a number of times already.

Yes, I see you've updated the lock file in b2aa67a. Any chance you could also tag the release of 0.8.4 here on GitHub?

@m4b
Copy link
Owner

m4b commented Jan 11, 2021

ok i tagged it 0.8.4

@carlocab
Copy link
Author

Great! It builds on Apple M1 now: https://github.com/Homebrew/homebrew-core/pull/68743/checks?check_run_id=1678656566

Thanks so much; you've been very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants