Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust-dependent formulae on Apple Silicon - upstream issue tracker #68301

Closed
40 tasks done
carlocab opened this issue Jan 4, 2021 · 16 comments
Closed
40 tasks done

Rust-dependent formulae on Apple Silicon - upstream issue tracker #68301

carlocab opened this issue Jan 4, 2021 · 16 comments
Labels
11-arm64 Big Sur arm64 is specifically affected help wanted Task(s) needing PRs from the community or maintainers outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue

Comments

@carlocab
Copy link
Member

carlocab commented Jan 4, 2021

There are a number of formulae that are not building with Rust 1.49 on Apple Silicon because of stale Cargo.lock files. (Cf. #68089) Only upstream can update this, so we need to open issues upstream asking them for an updated lock file.

Why is this needed?

We need the Cargo.lock files to updated because our cargo builds use the --locked flag, and these builds will fail when the lock file is stale. Removing the --locked flag isn't an option, because:

  1. We don't like unversioned dependencies. [1]
  2. We like reproducible builds.
  3. Builds with unpinned dependencies are prone to breakage when their dependencies upgrade to an incompatible version.

For more context, see: #46025, Homebrew/brew#10205

For each formula listed below:

  1. File an upstream issue for the relevant formula regarding the stale Cargo.lock file. If they're willing to cut a new release to update their lock file, that would be helpful.
  2. Link upstream issues here so we can track them.
  3. When upstream updates their lock file, open a PR here in homebrew/core to update the relevant formula.
    • If they cut a new release with the updated lock file, this PR will just be a simple version bump.
    • If they don't, then the formula will need to be patched. Please include a comment before your patch with details on when the patch can be removed. (e.g. a commit to track, an upstream issue, etc.)

If you want to help, feel free to do the above steps for any formula below that doesn't have an upstream issue filed yet.

@richiksc

This comment has been minimized.

@carlocab

This comment has been minimized.

@richiksc

This comment has been minimized.

@richiksc
Copy link
Contributor

@carlocab New tracking issue for wasm-pack: rustwasm/wasm-pack#959

master@HEAD builds succesfully with --locked on my local M1 Mac.

@richiksc
Copy link
Contributor

boringtun builds succesfully with --locked on HEAD. However, running boringtun utun (the test command) fails.

@carlocab
Copy link
Member Author

That sounds like it needs a separate bug report. Do you mind opening one, @richiksc?

@richiksc
Copy link
Contributor

Looks like I just needed to run with sudo. boringtun will be ARM-compatible on the next release, since it works on master.

@carlocab
Copy link
Member Author

Might still be a problem, though, as I'm not sure we can use sudo in a test block. We'll have to figure out a way around that at some point.

@SMillerDev
Copy link
Member

We don't use sudo anywhere in brew, so that's not a good solution. Can't we check for an expected error instead?

@smartin

This comment has been minimized.

@carlocab
Copy link
Member Author

Looks like a network problem, and isn't related to this issue. Please check your connection (e.g. if you have something like Little Snitch, please deactivate it) and try again.

If that doesn't help, you can ask for help at https://github.com/Homebrew/discussions/discussions.

@cprecioso
Copy link
Contributor

volta has an open issue on volta-cli/volta#977. However it is not clear if any action is needed as it already works well when using --build-from-source. Can we enable bottles for it now?

@nandahkrishna
Copy link
Member

@cprecioso volta has been bottled for ARM in 11e6a36, thanks.

@cho-m
Copy link
Member

cho-m commented Apr 19, 2022

Updated list. Only rustscan is not bottled on Apple Silicon. There are at least 3 different PRs related to this upstream:

@amadejpapez
Copy link
Contributor

New RustScan release 2.1.0 has just been made!

@cho-m
Copy link
Member

cho-m commented Apr 27, 2022

Closing as all tasks are done.

@cho-m cho-m closed this as completed Apr 27, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label May 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
11-arm64 Big Sur arm64 is specifically affected help wanted Task(s) needing PRs from the community or maintainers outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants