Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-pack: update stale lockfile #68836

Closed

Conversation

richiksc
Copy link
Contributor

@richiksc richiksc commented Jan 12, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

cc @carlocab [CI-force-arm]

@BrewTestBot BrewTestBot added missing license Formula has a missing license which should be added no ARM bottle Formula has no ARM bottle rust Rust use is a significant feature of the PR or issue labels Jan 12, 2021
@carlocab carlocab added the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Jan 12, 2021
@carlocab
Copy link
Member

That test outcome does not look right at all. Probably should be reported upstream.

@richiksc
Copy link
Contributor Author

richiksc commented Jan 12, 2021

That test outcome does not look right at all. Probably should be reported upstream.

Yeah, I got the same test failure locally. Let's see if wasm-pack new works when installed from master.

@richiksc
Copy link
Contributor Author

Interesting, this is a known issue upstream: rustwasm/wasm-pack#907

However, we only get that error on 11-arm CI. They are not on Apple Silicon, I'm assuming, as the issue was opened in August.

@richiksc
Copy link
Contributor Author

I also have the same issue when I build from master with an updated lockfile.

@richiksc richiksc force-pushed the wasm-pack-patch-cargo-lock branch from d23ce8d to db5199a Compare January 12, 2021 17:15
@BrewTestBot BrewTestBot removed the missing license Formula has a missing license which should be added label Jan 12, 2021
@SeekingMeaning SeekingMeaning added 11-arm64 Big Sur arm64 is specifically affected test failure CI fails while running the test-do block labels Jan 26, 2021
@BrewTestBot
Copy link
Member

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@BrewTestBot BrewTestBot added the stale No recent activity label Feb 17, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
11-arm64 Big Sur arm64 is specifically affected CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. no ARM bottle Formula has no ARM bottle outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue stale No recent activity test failure CI fails while running the test-do block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants