Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated Cargo.lock file? #130

Closed
carlocab opened this issue Jan 5, 2021 · 6 comments
Closed

Outdated Cargo.lock file? #130

carlocab opened this issue Jan 5, 2021 · 6 comments

Comments

@carlocab
Copy link

carlocab commented Jan 5, 2021

angle-grinder is currently failing to build for Homebrew with Rust 1.49 on Apple Silicon: Homebrew/homebrew-core#68089

It appears this is due to a stale lock file, causing cargo install --locked to pull in dependencies that do not work for angle-grinder on Apple Silicon. Is it possible for the Cargo.lock file to be updated? If this could be done with a new release, that would be especially helpful.

Related: Homebrew/homebrew-core#68301

@richiksc
Copy link

@carlocab Looks like this should have been fixed in #131. Do we just need a new point release for Homebrew?

@rcoh Do you know when you're planning to make a new release?

@carlocab
Copy link
Author

carlocab commented Jan 10, 2021

I've opened a PR to update the lock file that Homebrew uses: Homebrew/homebrew-core#68729

Let's see if that helps. It seems to work. We'll just need to remember to remove my monkey-patched lock file at the next version bump..

@carlocab
Copy link
Author

Thanks for the update, @rcoh! I've confirmed that the new Cargo.lock file enables building on Apple M1.

@rcoh
Copy link
Owner

rcoh commented Jan 10, 2021

Great, will cut a new release today–need to finish switching to GH actions from travis

@rcoh
Copy link
Owner

rcoh commented Jan 18, 2021

v0.16 has been cut—assets et al should be available in 20-30 minutes. Feel free to reopen if there are any issues.

@rcoh rcoh closed this as completed Jan 18, 2021
@carlocab
Copy link
Author

Thanks. I've opened Homebrew/homebrew-core#69287 to update angle-grinder at Homebrew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants