Test and build failures found during python 3.9 testing

[Rylan12]

Here are a list of issues that need to be resolved after the most recent [email protected] run (#66268):

• asuka — test (11.0) dd308e7
• augustus — test (11.0) 2d6844e
• cargo-edit — test 51524bd
• corral — test (11.0) d0b6db0
• couchdb-lucene — test
• creduce — test (11.0) eb6abcf
• cucumber-cpp — test (10.14) cucumber-cpp: fix test #67689
• diff-pdf — fetch poppler 20.12.1 #66369
• envoy — install (11.0) d275c94
• glyr — test glyr: fix test, update license #70505
• get-flash-videos — test (11.0)
• hyperkit — test
• innotop — test (11.0) 0247865
• mapnik — linkage, fetch mapnik: revision for gdal #65895
• mariadb — install mariadb*, mysql*, percona-server: fix CI test issues #66727
• [email protected] — install mariadb*, mysql*, percona-server: fix CI test issues #66727
• [email protected] — install mariadb*, mysql*, percona-server: fix CI test issues #66727
• [email protected] — install mariadb*, mysql*, percona-server: fix CI test issues #66727
• [email protected] — install mariadb*, mysql*, percona-server: fix CI test issues #66727
• [email protected] — test mariadb*, mysql*, percona-server: fix CI test issues #66727
• [email protected] — test mariadb*, mysql*, percona-server: fix CI test issues #66727
• networkit — test (11.0) 5bf8e35
• oclgrind — install (11.0) oclgrind 21.10 #87696
• odin — test (11.0) Odin fails brew test on Big Sur odin-lang/Odin#792, odin: add patch to fix test #66906
• pcl — test boost 1.75 #66792
• percona-server — install mariadb*, mysql*, percona-server: fix CI test issues #66727
• pipgrip — test (10.14, 11.0) pipgrip 0.6.2 #66814
• pony-stable — test (11.0) c0ef804
• ponyc — test (11.0) ponyc 0.38.2 #67765
• pypy — install (11.0) 1eaf5df
• pypy3 — install (11.0) 9eacad0
• root — test (11.0) a5af797
• stubby — test (11.0) 15b1fb8
• wrangler — install --only-dependencies (11.0) 8d4fa24

CI logs

10.14:

Error: 15 failed steps!
brew test --retry --verbose cargo-edit
brew test --retry --verbose cucumber-cpp
brew test --retry --verbose glyr
brew test --retry --verbose hyperkit
brew linkage --test mapnik
brew install mariadb
brew install [email protected]
brew install [email protected]
brew install [email protected]
brew install [email protected]
brew test --retry --verbose [email protected]
brew test --retry --verbose [email protected]
brew test --retry --verbose pcl
brew install percona-server
brew test --retry --verbose pipgrip

10.15:

Error: 13 failed steps!
brew test --retry --verbose cargo-edit
brew test --retry --verbose glyr
brew test --retry --verbose hyperkit
brew linkage --test mapnik
brew install mariadb
brew install [email protected]
brew install [email protected]
brew install [email protected]
brew install [email protected]
brew test --retry --verbose [email protected]
brew test --retry --verbose [email protected]
brew test --retry --verbose pcl
brew install percona-server

11.0:

Error: 26 failed steps!
brew test --retry --verbose asuka
brew test --retry --verbose augustus
brew test --retry --verbose cargo-edit
brew test --retry --verbose corral
brew test --retry --verbose creduce
brew test --retry --verbose glyr
brew test --retry --verbose hyperkit
brew test --retry --verbose innotop
brew linkage --test mapnik
brew install mariadb
brew install [email protected]
brew install [email protected]
brew install [email protected]
brew install [email protected]
brew test --retry --verbose [email protected]
brew test --retry --verbose [email protected]
brew test --retry --verbose networkit
brew install --only-dependencies oclgrind
brew install oclgrind
brew test --retry --verbose odin
brew test --retry --verbose pcl
brew install percona-server
brew test --retry --verbose pipgrip
brew test --retry --verbose pony-stable
brew test --retry --verbose ponyc
brew test --retry --verbose root

[carlocab]

Odin is broken on Big Sur; I've tried looking into it but there's little I could do without diving into their codebase: odin-lang/Odin#792

Root is also a known test failure: #65000

Hopefully the version bump will fix it: #65825

Mapnik linkage failure in progress: #65895

[carlocab]

CI Logs here may also be helpful:

10.14 https://github.com/Homebrew/homebrew-core/suites/1617574284/artifacts/29929186
10.15 https://github.com/Homebrew/homebrew-core/suites/1617574284/artifacts/29929187
11.0 https://github.com/Homebrew/homebrew-core/suites/1617574284/artifacts/29929188

[EwoutH]

FYI: Python 3.9.1 got released today! It might help resolve a few of the bugs and it also supports macOS 11 Big Sur.

[fxcoudert]

@EwoutH the title was misleading, these are not actually Python-related bugs, they were just found during our systematic testing of the latest python build

[sharris40]

At least one problem with all the MySQL forks is because they all use the same data directory, and it’s obviously a really bad idea to nuke that directory automatically outside of testing. This begs the question: Why are they all using the same data directory?

[carlocab]

openssl was merged in order to ship a security update. The following failures also need to be investigated (duplicates of OP under the fold):

• couchdb-lucene (test)
• diff-pdf (fetch)
• envoy (install, 11.0)
• get-flash-videos (test, 11.0)
• mapnik (fetch, 10.14, 10.15, 11.0)
• pypy (install, 11.0)
• pypy3 (install, 11.0)
• stubby (test, 11.0)
• wrangler (install --only-dependencies, 11.0)

Duplicates

• asuka (test, 11.0)
• augustus (test, 11.0)
• cargo-edit (test)
• corral (test, 11.0)
• creduce (test, 11.0)
• cucumber-cpp (test, 10.14)
• glyr (test, 10.14, 11.0)
• hyperkit (test, 10.14, 10.15)
• innotop (test, 11.0)
• mariadb (install)
• [email protected] (install)
• [email protected] (install)
• [email protected] (install)
• [email protected] (install)
• [email protected] (test)
• [email protected] (test)
• networkit (test, 11.0)
• oclgrind (install, 11.0)
• odin (test, 11.0)
• pcl (test)
• percona-server (install)
• pipgrip (test, 10.14, 11.0)
• pony-stable (test, 11.0)
• ponyc (test, 11.0)
• root (test, 11.0)

CI run logs: https://github.com/Homebrew/homebrew-core/pull/66501/checks?check_run_id=1519709728

[carlocab]

Tried building mariadb locally. Built and tested fine. Not sure why CI is stuck on it. Will take a closer look at the logs.

[carlocab]

All versions of mariadb (at least, in the openssl CI run) are failing in the post-install step: post_install.01.mysql_install_db.txt

Looks to me like a CI problem rather than a build problem. Could be wrong though.

If you've got a minute, maybe you want to take a look, @fxcoudert.

[fxcoudert]

I've looked at mariadb and I have no idea. I can't reproduce it locally. I think it may be because it's reading conflicting configuration files from another DB-related formula that gets installed before during CI.

[mitchblank]

innotop is unrelated breakage -- attempting a fix here: #66699

likely creduce is the same root-cause since they both use the TermReadKey perl package which requires build tweaks on newer MacOS

[gromgit]

For MariaDB, I think it makes more sense to take a page from the PostgreSQL formulae, and make post-install return if ENV["CI"], instead of trying to touch whatever crud is left over in /usr/local/var/mysql on the CI box. Then the test block can do a proper mysql_install_db in the sandbox, plus whatever else makes sense.

Just opened #66727 as PoC.

[SMillerDev]

See #60190 as well for a running attempt

[sharris40]

percona-server is another MySQL fork that should get similar treatment.

[carlocab]

No new failures from the version bump to 3.9.1: #66489

@fxcoudert

[Rylan12]

Just updated the original list with some links to open PRs. Also added the new failures that @carlocab mentioned above.

[carlocab]

I think I've fixed pcl here: #66792

[carlocab]

Also, I think the mapnik bottle is missing, which is causing fetch errors:

❯ brew fetch mapnik
==> Downloading https://homebrew.bintray.com/bottles/mapnik-3.0.23_4.catalina.bottle.tar.gz
#=#=#
curl: (22) The requested URL returned error: 404 Not Found
Error: Failed to download resource "mapnik"
Download failed: https://homebrew.bintray.com/bottles/mapnik-3.0.23_4.catalina.bottle.tar.gz

[Rylan12]

Yep, looking at that now. They're definitely missing. Not sure what happened. I'll see if I can find them and upload them.

[carlocab]

I've confirmed that pcl is fixed at #66792. However, there are some other CI failures I'd appreciate some help with.

[gromgit]

#66727 is merged, so all of mariadb*, mysql* and percona-server should be OK now.

[dtrodrigues]

From #69668

ARM
brew test --retry --verbose emscripten
brew test --retry --verbose tree-sitter

11.0
brew test --retry --verbose howdoi
brew test --retry --verbose pinboard-notes-backup

10.15
brew test --retry --verbose pinboard-notes-backup

10.14
brew test --retry --verbose cp2k
brew test --retry --verbose howdoi
brew test --retry --verbose nwchem
brew test --retry --verbose swift

[carlocab]

Merged #71329 for CVE fixes.

Mojave only:

brew test --retry --verbose gallery-dl
brew test --retry --verbose opencascade

All Intel nodes:

brew test --retry --verbose wasm-pack

[carlocab]

howdoi and youtube-dlc need new tests. From #74538. (Will try to find time to do this soon.)

Update:

• youtube-dlc is an upstream issue. NoneType Object has no attribute 'get' Error blackjack4494/yt-dlc#305
• howdoi should be fixed by howdoi: update test #74677

[Git-Jiro]

Hi!
Is the list in the first post still up to date?

I just tried:

brew install asuka --include-test --build-from-source
brew test asuka
brew install augustus --include-test --build-from-source
brew test augustus
brew install cargo-edit --include-test --build-from-source
brew test cargo-edit

And that seems to work fine on macOS 11.6 (intel)

[carlocab]

Thanks for having a look, @Git-Jiro. Most of those failures have been fixed. I think there may be a few that are still outstanding. I'll try to update the checklist.

[Git-Jiro]

Another small update:

brew install corral --include-test --build-from-source

This did NOT work on my machine.
I got some compiler errors, from the pony compiler.

Those here:

brew install couchdb-lucene --include-test --build-from-source
brew test couchdb-lucene
brew install get-flash-videos --include-test --build-from-source
brew test getf-flash-videos
brew install oclgrind --include-test --build-from-source
brew test oclgrind

also worked fine.

[mitchblank]

oclgrind got updated today including a brew test fix which may have been the cause of the earlier failure: #87696 So it can be checked off now

[iMichka]

I'm going to close this. This has started with a tracking list and then more issues have been added, so that an issue initially started in Dec 2020 is still open now. We will fix the remaining issues as they pop up, or re-open a new tracking list if necessary.

I also think we should look for a better tool to track known broken tests/formulae, maybe with some database / service. Not sure what exists out there.