innotop: fix build on 10.15+ #66699
innotop: fix build on 10.15+ #66699
Conversation
The TermReadKey perl package fails to build due to a restriction apple added on dealing with .bundle files by their relative path name. This was diagnosed in 2019 by fink and I am adapting a workaround that @TheSin- proposed then: fink/fink-distributions#461 (comment) Also: - bump the sub-resources to their most recent versions while here - build failed until I added Devel::CheckLib too
|
BTW, this same approach will probably need to be applied to other TermReadKey using formulae: po4a, creduce, and rex. Will see how this one goes first before attempting those. |
| # from a relative path -- while in the middle of our build we need to | ||
| # refer to them by their full path. Workaround adapted from: | ||
| # https://github.com/fink/fink-distributions/issues/461#issuecomment-563331868 | ||
| inreplace "Makefile", "blib/", "$(shell pwd)/blib/" if r.name == "TermReadKey" |
There was a problem hiding this comment.
I think $PWD here is actually #{buildpath}/#{r.name}.
There was a problem hiding this comment.
Eh, seems safer and simpler to just have make figure it out when it runs. That way it's less likely to break if things get rearranged. It only has to run a few times, so no real performance concern about running a few extra /bin/pwd commands.
There was a problem hiding this comment.
BTW, my first thought was to use Pathname.pwd since that is what other fomulae seem to do, but it didn't work for some reason. But I'm pretty happy with this solution so I didn't research further.
|
@mitchblank thanks a lot for the fix, I will try it out on the po4a side. |
|
🤖 A scheduled task has triggered a merge. |
|
I was trying out this fix in po4a side, but it seems not quite working as expected. |
|
I forgot how I patched po4a feel free to check the history in fink I might have had to add more |
The
TermReadKeyperl package fails to build due to a restriction apple added on dealing with .bundle files by their relative path name. This was diagnosed in 2019 by fink and I am adapting a workaround that @TheSin- proposed then: fink/fink-distributions#461 (comment)