Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readline 8.1 #66472

Closed
wants to merge 1 commit into from
Closed

readline 8.1 #66472

wants to merge 1 commit into from

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Dec 8, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@fxcoudert
Copy link
Member

On 10.14:

brew test --retry --verbose cargo-edit
brew test --retry --verbose couchdb-lucene
brew test --retry --verbose cucumber-cpp
brew fetch --retry diff-pdf
brew test --retry --verbose dnstwist
brew test --retry --verbose glyr
brew test --retry --verbose hyperkit
brew fetch --retry mapnik
brew install mariadb
brew install [email protected]
brew install [email protected]
brew install [email protected]
brew install [email protected]
brew test --retry --verbose [email protected]
brew test --retry --verbose [email protected]
brew test --retry --verbose pcl
brew install percona-server
brew test --retry --verbose pipgrip
brew test --retry --verbose renameutils

@sharris40
Copy link
Contributor

Most of those failures are reported in #66450, and diff-pdf in #66385. That leaves couchdb-lucene, dnstwist, and renameutils.

@bayandin
Copy link
Member Author

bayandin commented Dec 9, 2020

Can't reproduce problems with dnstwist, but was able to fix it in elceef/dnstwist#115.
If it happens again — will backport the patch

@bayandin
Copy link
Member Author

bayandin commented Dec 9, 2020

Also can't reproduce locally renameutils failure:

==> /usr/local/Cellar/renameutils/0.12.0_3/bin/icp test.txt
/usr/local/Cellar/renameutils/0.12.0_3/bin/icp: cannot execute gcp: No such file or directory

it complaints about missing gcp which is a part of coreutils and renameutils has it as a dependency.

@bayandin
Copy link
Member Author

bayandin commented Dec 9, 2020

10.15 (Catalina) failures:

brew test --retry --verbose cargo-edit
brew test --retry --verbose couchdb-lucene
brew fetch --retry diff-pdf
brew test --retry --verbose glyr
brew test --retry --verbose hyperkit
brew fetch --retry mapnik
brew install mariadb
brew install [email protected]
brew install [email protected]
brew install [email protected]
brew install [email protected]
brew test --retry --verbose [email protected]
brew test --retry --verbose [email protected]
brew test --retry --verbose pcl
brew install percona-server
brew test --retry --verbose renameutils

@carlocab
Copy link
Member

carlocab commented Dec 9, 2020

Fixing 10.14 failures here will also fix 10.14 failures in openssl version bump: #66501 (comment)

@BrewTestBot
Copy link
Member

:shipit: @fxcoudert has triggered a merge.

@fxcoudert
Copy link
Member

Please collate and investigate all the unrelated issues found during testing. I will merge in the meantime.

@bayandin bayandin deleted the bump-readline-8.1 branch December 10, 2020 13:48
@carlocab
Copy link
Member

carlocab commented Jan 3, 2021

There might be a bug in this version of readline: #68193 (comment)

@dtrodrigues
Copy link
Member

Not a readline bug, but a change in the default value of enable-bracketed-paste from off to on.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 3, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants