Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openblas 0.3.13 #66821

Closed
wants to merge 1 commit into from
Closed

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Dec 12, 2020

Created with brew bump-formula-pr.

Formula CI Failure Version Comment
mapnik fetch 10.14,10.15,11.0 #65895
networkit test 10.15,11.0 #66450

@chenrui333
Copy link
Member

 gcc-ranlib ../../libopenblasp-r0.3.13.a
 make[2]: gcc-ranlib: No such file or directory
 make[2]: *** [../../libopenblasp-r0.3.13.a] Error 1
 make[1]: *** [lapacklib] Error 2
 make: *** [netlib] Error 2

@chenrui333 chenrui333 added the build failure CI fails while building the software label Dec 13, 2020
@carlocab
Copy link
Member Author

carlocab commented Dec 13, 2020

Ah. That's because it needs gcc-ranlib-10, but is trying to call it as gcc-ranlib.

Formula/openblas.rb Outdated Show resolved Hide resolved
@carlocab carlocab force-pushed the bump-openblas-0.3.13 branch from f15a1e4 to 2b7247f Compare December 13, 2020 16:16
Formula/openblas.rb Outdated Show resolved Hide resolved
Formula/openblas.rb Outdated Show resolved Hide resolved
@carlocab
Copy link
Member Author

10.14:

Error: 1 failed steps!
brew fetch --retry mapnik

Should hopefully be fixed in #65895

@fxcoudert
Copy link
Member

Upstream issue: OpenMathLib/OpenBLAS#3037

@fxcoudert
Copy link
Member

This is actually a real openblas bug, so let's not merge and wait for a proper fix: OpenMathLib/OpenBLAS#3037 (comment)

@carlocab
Copy link
Member Author

carlocab commented Dec 13, 2020

11.0

Error: 2 failed steps!
brew fetch --retry mapnik
brew test --retry --verbose networkit

networkit failure is documented here: #66450

10.15

Error: 1 failed steps!
brew fetch --retry mapnik

@carlocab
Copy link
Member Author

carlocab commented Dec 14, 2020

I actually think this is ready to merge. The CI failures are documented elsewhere, and the upstream fix affects the build only. Of course, one can be concerned about bitrot, so I'm willing to wait for a little while too.

@fxcoudert
Copy link
Member

I'd prefer to use the upstream patch, clearly noting that it can be removed in the next version: OpenMathLib/OpenBLAS#3038

Otherwise we'll forget to remove that RANLIB thing, and also there might be other issues by the build thinking it's cross-compiled

@carlocab carlocab force-pushed the bump-openblas-0.3.13 branch from 13120bd to a8dfd13 Compare December 15, 2020 16:41
- patch build script to avoid spurious cross-compilation.

Cf. OpenMathLib/OpenBLAS#3038

Co-authored-by: FX Coudert <[email protected]>
@carlocab carlocab force-pushed the bump-openblas-0.3.13 branch from a8dfd13 to a5405a0 Compare December 15, 2020 16:43
@carlocab
Copy link
Member Author

I think auto-merge is skipping this?

@SMillerDev SMillerDev removed the build failure CI fails while building the software label Dec 16, 2020
@SMillerDev SMillerDev requested a review from fxcoudert December 16, 2020 12:43
@BrewTestBot
Copy link
Member

:shipit: @fxcoudert has triggered a merge.

@carlocab carlocab deleted the bump-openblas-0.3.13 branch December 16, 2020 14:51
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 16, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants