Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odin: add patch to fix test #66906

Closed
wants to merge 1 commit into from
Closed

odin: add patch to fix test #66906

wants to merge 1 commit into from

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Dec 14, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Fix the test for 11.0 for #66450

This was reported upstream in odin-lang/Odin#792 and was resolved in odin-lang/Odin#768. The patch does not apply cleanly, so I needed to rewrite it.

@carlocab
Copy link
Member

That was on my to-do list. Though it had been there for a while now. Thanks for fixing this!

@Rylan12
Copy link
Member Author

Rylan12 commented Dec 14, 2020

That was on my to-do list. Though it had been there for a while now.

Story of my life

@carlocab
Copy link
Member

Ah, now I remember why I left it. I remember trying to build Odin off their master branch using brew install --HEAD and that didn't work either. That then gave me the impression that it would take more work to fix, and gave up. Guess I should've persisted for a bit longer...

@Rylan12
Copy link
Member Author

Rylan12 commented Dec 14, 2020

Hmm maybe we'll have to deal with that when there's a new release... 😦

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@Rylan12 Rylan12 deleted the odin-fix branch December 15, 2020 16:23
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 15, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants