Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcb2gcode 2.2.2 #68428

Closed
wants to merge 4 commits into from
Closed

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Jan 7, 2021

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added the no ARM bottle Formula has no ARM bottle label Jan 7, 2021
@carlocab carlocab mentioned this pull request Jan 7, 2021
5 tasks
@carlocab
Copy link
Member

carlocab commented Jan 8, 2021

Seems like the vendored boost can be dropped? #30914 (comment)

Don't think it'll help the failures though...

Signed-off-by: Rui Chen <[email protected]>
@chenrui333
Copy link
Member Author

try out boost 1.75 per pcb2gcode/pcb2gcode#494

@chenrui333 chenrui333 added build failure CI fails while building the software upstream issue An upstream issue report is needed labels Jan 18, 2021
@chenrui333 chenrui333 changed the title pcb2gcode 2.2.0 pcb2gcode 2.2.2 Jan 18, 2021
@carlocab
Copy link
Member

❯ brew unbottled --tag=arm64_big_sur pcb2gcode
==> Populating dependency tree...
==> :arm64_big_sur bottle status
pcb2gcode: ready to bottle

Should we try an ARM build?

@carlocab
Copy link
Member

carlocab commented Jan 19, 2021

This is the build error.

checking for glibmm-2.4 >= 2.8... no
configure: error: Package requirements (glibmm-2.4 >= 2.8) were not met:

No package 'glibmm-2.4' found

Not sure if they need something newer than 2.4 (we have 2.68), or they just really need 2.4. The 2.8 is confusing, since glibmm-2.8 appears to be a very old version. [1] glibmm seems to have changed version schemes at some point.

[1] https://download.gnome.org/sources/glibmm/

@chenrui333
Copy link
Member Author

❯ brew unbottled --tag=arm64_big_sur pcb2gcode
==> Populating dependency tree...
==> :arm64_big_sur bottle status
pcb2gcode: ready to bottle

Should we try an ARM build?

i think it would be the same thing.

@chenrui333
Copy link
Member Author

This is the build error.

checking for glibmm-2.4 >= 2.8... no
configure: error: Package requirements (glibmm-2.4 >= 2.8) were not met:

No package 'glibmm-2.4' found

Not sure if they need something newer than 2.4 (we have 2.68), or they just really need 2.4. The 2.8 is confusing, since glibmm appears to be a very old version. [1] glibmm seems to have changed version schemes at some point.

[1] https://download.gnome.org/sources/glibmm/

we are doing glibmm-2.68, i think it is sufficient. (-lglibmm-2.68)

@carlocab
Copy link
Member

Maybe there's a problem in their build script? (Or perhaps pkg-config) Since it doesn't seem to think glibmm-2.68 satisfies the requirement.

@chenrui333
Copy link
Member Author

Maybe there's a problem in their build script? (Or perhaps pkg-config) Since it doesn't seem to think glibmm-2.68 satisfies the requirement.

yeah, that is what I think, this is indeed pretty weird.

@chenrui333
Copy link
Member Author

Gonna close this one, revisit later.

@chenrui333 chenrui333 closed this Jan 27, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 27, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 27, 2021
@chenrui333 chenrui333 deleted the bump-pcb2gcode-2.2.0 branch December 18, 2022 05:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build failure CI fails while building the software no ARM bottle Formula has no ARM bottle outdated PR was locked due to age upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants